<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103825/">http://git.reviewboard.kde.org/r/103825/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 29th, 2012, 6:45 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td><a href="/r/103825/s/422/" style="color: black; font-weight: bold; font-size: 9pt;">joinchatroom.png</a></td>
</tr>
<tr>
<td><a href="http://git.reviewboard.kde.org/r/103825/s/422/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/01/29/joinchatroom_34_378_308_48.png" style="border: 1px black solid;" alt="Dialog with roomlist"></a></td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Search in rooms..."
I don't think the "in" is needed, unless it actually searches inside the room.
Also what's the rules on "...". In the case of buttons it means new window, not sure it has any meaning here. Discuss.
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Searching for a contact inside of rooms indeed would be cool :-P
Joking apart. You are right, it simply should be "Search rooms".
About the "...", I took my inspiration from send-file. I considered the "..." as a prompt for the user to put some text in there, but that's a somewhat odd because it is already a clickMessage.</pre>
<br />
<p>- Dominik</p>
<br />
<p>On January 29th, 2012, 6:36 p.m., Dominik Cermak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Cermak.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2012, 6:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds support for showing available rooms. You can query the default server of the selected account or specify a server yourself.
The list shows if the room is password protected, how many persons are there, the name and the description.
Suggestions for a better design are welcome.
Maybe make the labels of the first to lineedits also a clickMessage?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with XMPP.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=291711">291711</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e57d3895981c0d2b5a6f35e3e4265fca86e4ec28)</span></li>
<li>dialogs/join-chat-room-dialog.h <span style="color: grey">(d0aba22bba3f271294bcaeae4b0e2527d200ac87)</span></li>
<li>dialogs/join-chat-room-dialog.cpp <span style="color: grey">(164f910aa7d06bab3ca3f7d9d472aa6d2d5ed09f)</span></li>
<li>dialogs/join-chat-room-dialog.ui <span style="color: grey">(6c64151b629139a69e21b85b09c7c57498f2cd8a)</span></li>
<li>rooms-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>rooms-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103825/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103825/s/422/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/01/29/joinchatroom_400x100.png" style="border: 1px black solid;" alt="Dialog with roomlist" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>