<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103738/">http://git.reviewboard.kde.org/r/103738/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6510aa20ece700d845a9a984a0f84205e0374e3a by David Edmundson to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 19th, 2012, 5:52 p.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2012, 5:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Base the spinner in global presence off when an account is in ConnectionStatusConnecting rather changingPresence.
It turns out changingPresence is rubbish, some accounts just sit there with it constantly on if requested to go into a state they can't handle.
I'm not sure whether spinning each time you change presence was a good idea anyway. (it was mine)
This patch is related to a patch in common internals about to be uploaded. (add connection status to global presence)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>global-presence-chooser.h <span style="color: grey">(2c4a0ec)</span></li>
<li>global-presence-chooser.cpp <span style="color: grey">(8ebfc1c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103738/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>