<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103592/">http://git.reviewboard.kde.org/r/103592/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d2969fa850ec3caf273dd7569f7a004721c2c69b by Florian Reinhard to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 5th, 2012, 9:03 p.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2012, 9:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When no connection manager installed, the KCM would show broken dialogs for jabber, google-talk and facebook chat because of the shipped profile files.
The patch makes the kcm module now check if the connection manager for the required profile exists.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">clicked all buttons with no connection manager at all installed => installation required
clicked all buttons with the required connection managers installed => properties dialog</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/add-account-assistant.cpp <span style="color: grey">(3f189b440ddf26af4092af6ac11e247838087254)</span></li>
<li>src/KCMTelepathyAccounts/CMakeLists.txt <span style="color: grey">(d886b452c7cdc7704627be002f390f8e6ff4d7bb)</span></li>
<li>src/KCMTelepathyAccounts/profile-list-model.h <span style="color: grey">(e3c7cddc17feb019f55ae7f8fcbeb040ea840e16)</span></li>
<li>src/KCMTelepathyAccounts/profile-list-model.cpp <span style="color: grey">(6c4b08a94deb3a36e09bc6f085ba4acfb68b4bcf)</span></li>
<li>src/KCMTelepathyAccounts/profile-select-widget.h <span style="color: grey">(8f3ad2a47b3deb818da76d8a38c4884507440f3f)</span></li>
<li>src/KCMTelepathyAccounts/profile-select-widget.cpp <span style="color: grey">(be0d41fdb4761d04be16107b534714f8cb93a01b)</span></li>
<li>src/KCMTelepathyAccounts/simple-profile-select-widget.h <span style="color: grey">(88caa0a85d5bb5c22c975f712dc452391c158211)</span></li>
<li>src/KCMTelepathyAccounts/simple-profile-select-widget.cpp <span style="color: grey">(5bb708d0b2508b37fd8c0181d445318800ed5112)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103592/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>