<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103562/">http://git.reviewboard.kde.org/r/103562/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 28th, 2011, 6:15 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103562/diff/4/?file=45011#file45011line172" style="color: black; font-weight: bold; text-decoration: underline;">src/add-account-assistant.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class AddAccountAssistant::Private</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">169</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KMessageBox</span><span class="o">::</span><span class="n">error</span><span class="p">(</span><span class="k">this</span><span class="p">,</span> <span class="s">"The required telepathy connection manager is not installed yet. Please install the appropriate telepathy-* packages."</span><span class="p">,</span><span class="s">"Missing Telepathy Connection Manager"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not very good message. It's too technical and doesn't really help much.
I suggest "To connect to this IM network, you need to install additional plugins. Please install telepathy-? packages using your package manager." Though this still not tell the user which packages he needs (saying install all might not be always good).
Can we tell the user what to install exactly by the button he clicked?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good point and the generic message would be:
To connect to this IM network, you need to install additional plugins. Please install the telepathy-haze and telepathy-gabble packages using your package manager.</pre>
<br />
<p>- Florian</p>
<br />
<p>On December 28th, 2011, 5:16 p.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2011, 5:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is not intended for master. Consider it to be a more detailed mockup, I know the code is crappy ;)
Draw backs:
* crashes from time to time because of ugly hacks in ProfileItem / SimpleProfileSelectWidget::selectedProfile()
* profile names are hardcoded, I guess this shouldn't stay this way?
* profiles from the first page are not excluded from the second page
* the naming of page one, two, three is hard to understand when reading the code
* if you click on "Other" you get was formerly was the entry page, one could use the new shiny buttons there too.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279046">279046</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KCMTelepathyAccounts/CMakeLists.txt <span style="color: grey">(0991b4dd3a65d34746e3c92d09c43c4cbced8e92)</span></li>
<li>src/KCMTelepathyAccounts/profile-item.h <span style="color: grey">(dc492a5e37192d91833348e1e1dfe9c96fe41f51)</span></li>
<li>src/KCMTelepathyAccounts/profile-item.cpp <span style="color: grey">(de42b521cbfb047dabf1c5c85decc47dceaac54e)</span></li>
<li>src/KCMTelepathyAccounts/profile-select-widget.h <span style="color: grey">(52c6f898728dab5ddd8c73548caeea99ac271efe)</span></li>
<li>src/KCMTelepathyAccounts/profile-select-widget.cpp <span style="color: grey">(dc8b9cc1d0bad9c856834c4e0dbae7b9102dee89)</span></li>
<li>src/KCMTelepathyAccounts/simple-profile-select-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/simple-profile-select-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/simple-profile-select-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/add-account-assistant.h <span style="color: grey">(9be243ffbe2d246042ed3684f696f0fccbc1252e)</span></li>
<li>src/add-account-assistant.cpp <span style="color: grey">(dee6e88c51c72f36a1e3099a272db71443a7194f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103562/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103562/s/384/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/28/kcm-accounts-step1-test5_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>