<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103562/">http://git.reviewboard.kde.org/r/103562/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 5207551faeae5ef54c55c492f84debb8a2a97374 by Florian Reinhard to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 28th, 2011, 5:16 p.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2011, 5:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is not intended for master. Consider it to be a more detailed mockup, I know the code is crappy ;)
Draw backs:
* crashes from time to time because of ugly hacks in ProfileItem / SimpleProfileSelectWidget::selectedProfile()
* profile names are hardcoded, I guess this shouldn't stay this way?
* profiles from the first page are not excluded from the second page
* the naming of page one, two, three is hard to understand when reading the code
* if you click on "Other" you get was formerly was the entry page, one could use the new shiny buttons there too.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279046">279046</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KCMTelepathyAccounts/CMakeLists.txt <span style="color: grey">(0991b4dd3a65d34746e3c92d09c43c4cbced8e92)</span></li>
<li>src/KCMTelepathyAccounts/profile-item.h <span style="color: grey">(dc492a5e37192d91833348e1e1dfe9c96fe41f51)</span></li>
<li>src/KCMTelepathyAccounts/profile-item.cpp <span style="color: grey">(de42b521cbfb047dabf1c5c85decc47dceaac54e)</span></li>
<li>src/KCMTelepathyAccounts/profile-select-widget.h <span style="color: grey">(52c6f898728dab5ddd8c73548caeea99ac271efe)</span></li>
<li>src/KCMTelepathyAccounts/profile-select-widget.cpp <span style="color: grey">(dc8b9cc1d0bad9c856834c4e0dbae7b9102dee89)</span></li>
<li>src/KCMTelepathyAccounts/simple-profile-select-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/simple-profile-select-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/simple-profile-select-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/add-account-assistant.h <span style="color: grey">(9be243ffbe2d246042ed3684f696f0fccbc1252e)</span></li>
<li>src/add-account-assistant.cpp <span style="color: grey">(dee6e88c51c72f36a1e3099a272db71443a7194f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103562/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103562/s/384/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/28/kcm-accounts-step1-test5_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>