<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103535/">http://git.reviewboard.kde.org/r/103535/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 26th, 2011, 1:16 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103535/diff/1/?file=44843#file44843line287" style="color: black; font-weight: bold; text-decoration: underline;">context-menu.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ContextMenu::onShowInfoTriggered()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">287</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ContactInfo</span> <span class="n">contactInfoDialog</span><span class="p">(</span><span class="n">item</span><span class="o">-></span><span class="n">contact</span><span class="p">(),</span> <span class="n">m_mainWidget</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">287</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">QPointer</span></span><span class="o"><span class="hl"><</span></span><span class="n">ContactInfo</span><span class="o"><span class="hl">></span></span> <span class="n">contactInfoDialog</span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="k"><span class="hl">new</span></span><span class="hl"> </span><span class="n"><span class="hl">ContactInfo</span></span><span class="p">(</span><span class="n">item</span><span class="o">-></span><span class="n">contact</span><span class="p">(),</span> <span class="n">m_mainWidget</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to Qt docs, you should prefer QWeakPointer over QPointer.
This also btw. does not fix anything as the dialog's data is never accessed, but if it makes Krazy happy, then so be it.</pre>
</blockquote>
<p>On December 26th, 2011, 1:20 p.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How does this help in anyway? If anything, it makes the code harder to understand, and (in the event that your care about exceptions) less exception-safe.</pre>
</blockquote>
<p>On December 26th, 2011, 1:36 p.m., <b>Dominik Cermak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's were krazy links to: http://blogs.kde.org/node/3919</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QPointer is deprecated for this kind of issues and should never be used - please follow Martin's advice and replace it with QWeakPointer.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 26th, 2011, 1:16 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103535/diff/1/?file=44845#file44845line236" style="color: black; font-weight: bold; text-decoration: underline;">global-presence-chooser.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool GlobalPresenceChooser::event(QEvent *e)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">236</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">Q</span>ComboBox</span><span class="o">::</span><span class="n">mousePressEvent</span><span class="p">(</span><span class="n">me</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">236</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">K</span>ComboBox</span><span class="o">::</span><span class="n">mousePressEvent</span><span class="p">(</span><span class="n">me</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have you tested this? I'm not sure if KComboBox does not reimplement this method and does some additional magic that could break this.</pre>
</blockquote>
<p>On December 26th, 2011, 1:36 p.m., <b>Dominik Cermak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It doesn't re-implement both of them. Anyway it brings no real benefit beside making krazy happy...
So change it or leave it?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should not affect the code itself. Although, QComboBox kinda makes the code clearer, at least to me, so I'd leave the Q one here. Remember, in these cases you can suppress krazy warnings like this: http://techbase.kde.org/Development/Tutorials/Code_Checking#Suppressing_false-positives</pre>
<br />
<p>- Dario</p>
<br />
<p>On December 26th, 2011, 1:10 p.m., Dominik Cermak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Cermak.</div>
<p style="color: grey;"><i>Updated Dec. 26, 2011, 1:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add KUIT context marker.
Normalize signatures.
Fix typos.
Use K-classes.
Use QPointers when showing modal dialogs via exec().
Fix null string assign.
Fix newline.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>account-button.cpp <span style="color: grey">(1bcc93c4f75c77f45be91723f53787660e6a6ae0)</span></li>
<li>contact-delegate-overlay.cpp <span style="color: grey">(2cae71f8e9a96e8cd6dce6bc1ac782937bd1d8bc)</span></li>
<li>context-menu.cpp <span style="color: grey">(e98392ea0ec73b89fc50bff64b8a0866177e551e)</span></li>
<li>dialogs/join-chat-room-dialog.ui <span style="color: grey">(4e90ebf407dbf0c0005f92d8ec8f18962f91dfdc)</span></li>
<li>global-presence-chooser.cpp <span style="color: grey">(935f58266bfdad801d98c8c93eafe3515669fd52)</span></li>
<li>tooltips/contacttooltip.cpp <span style="color: grey">(46981fa296ee22bedab9bb9cc385f2cc054f06a6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103535/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>