<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103521/">http://git.reviewboard.kde.org/r/103521/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 24th, 2011, 5:40 p.m., <b>Dario Freddi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103521/diff/1/?file=44654#file44654line65" style="color: black; font-weight: bold; text-decoration: underline;">x-messenger-oauth2-auth-operation.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void XMessengerOAuth2AuthOperation::onSASLStatusChanged(uint status, const QString &reason,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">65</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">m_dialog</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">66</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">loginPageLoaded</span><span class="p">(</span><span class="kt">bool</span><span class="p">)),</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_dialog</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">SLOT</span><span class="p">(</span><span class="n">show</span><span class="p">()));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see a potential focus issue here, given you are constructing the dialog without a parent at all. This might lead to the dialog appearing behind the windows in some cases, and failure in having the user properly notified. Is it possible to give it a parent somehow, maybe passing a widget to the operation?</pre>
</blockquote>
<p>On December 26th, 2011, 7:53 a.m., <b>Daniele Elmo Domenichelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We don't have any parent, the service is running in the background without any widget and the window just pops up like the password ones, so we don't have any widget to pass...
Do you have any suggestion about how to do this?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not really, that's kind of an unsolvable problem. In this case you just need to trust KWin for (hopefully) doing the right thing.</pre>
<br />
<p>- Dario</p>
<br />
<p>On December 26th, 2011, 8:11 a.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Dec. 26, 2011, 8:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Refactor SaslAuthOp to support different authentication methods, support X-MESSENGER-OAUTH2 authentication mechanism and make dialogs modeless
branch here: http://quickgit.kde.org/?p=scratch%2Fddomenichelli%2Ftelepathy-auth-handler.git&a=shortlog&h=refs/heads/oauth2
At the moment there is no support from the kcm, therefore you will have to add to your ~/.mission-control/accounts/accounts.cfg something like this:
[gabble/jabber/messenger_2elive_2ecom0]
manager=gabble
protocol=jabber
param-server=xmpp.messenger.live.com
param-account=messenger.live.com
param-ignore-ssl-errors=true
Another way to add it is to create a file /usr/share/telepathy/profiles/msn-xmpp.profile
<service xmlns="http://telepathy.freedesktop.org/wiki/service-profile-v1"
id="msn-xmpp"
type="IM"
provider="msn-xmpp"
manager="gabble"
protocol="jabber"
icon="im-msn">
<name>MSN (using XMPP)</name>
<parameters>
<parameter name="server" type="s" mandatory="1">xmpp.messenger.live.com</parameter>
<parameter name="port" type="u" mandatory="1">5222</parameter>
<parameter name="ignore-ssl-errors" type="b" mandatory="1">1</parameter>
<parameter name="account" type="s" mandatory="1">messenger.live.com</parameter>
</parameters>
</service>
And create a new account without changing anything
Finally you can just create a gabble account setting server "xmpp.messenger.live.com", account name messenger.live.com and enable ignore ssl errors in the advanced settings dialog</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can login to MSN using gabble/xmpp
Can still login using old method (either with password prompt or stored password)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=283307">283307</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=289668">289668</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1a263b66349074e8d409adfefd7d53af7d05a07d)</span></li>
<li>password-prompt.h <span style="color: grey">(fc686ca4be3cc88cc7f968f6fca6f8a2c89019fe)</span></li>
<li>password-prompt.cpp <span style="color: grey">(e23842913c33efce29ff9cc1f474c7acf0449c30)</span></li>
<li>password-prompt.ui <span style="color: grey">(7f5009e0f473bdb3c70a600b70a7f12b8fa6827d)</span></li>
<li>sasl-auth-op.h <span style="color: grey">(e58543b6de9b50e05f6d6c5e3ccabf6fa90bc2f3)</span></li>
<li>sasl-auth-op.cpp <span style="color: grey">(b65baacc4afa1323fd2392f621b3944d702138c1)</span></li>
<li>sasl-handler.cpp <span style="color: grey">(ad34e37e7f757dac1fda95c0f8e8dbece1aae9af)</span></li>
<li>x-messenger-oauth2-auth-operation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>x-messenger-oauth2-auth-operation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>x-messenger-oauth2-prompt.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>x-messenger-oauth2-prompt.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>x-telepathy-password-auth-operation.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>x-telepathy-password-auth-operation.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>x-telepathy-password-prompt.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>x-telepathy-password-prompt.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>x-telepathy-password-prompt.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103521/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>