<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103502/">http://git.reviewboard.kde.org/r/103502/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You changed FindTp, but I see no mention of changing the include paths in any cpp/h file, which should become KTp/ from KTelepathy/. Be sure to remove the old include directories.</pre>
<br />
<p>- Dario</p>
<br />
<p>On December 22nd, 2011, 12:20 p.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2011, 12:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This has actually lots of libraries, so I named the main kcm one according to the kcm scheme, its internal library is now 'libktpaccountskcminternal', while the plugins are 'ktpaccountskcm_plugin_X.so', which I'm not sure about. Should I turn it to 'libktpaccountskcm_plugin_X.so' or 'libktpaccountskcmpluginX.so'?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Successfully created an account. Everything works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2a9aef2)</span></li>
<li>cmake/modules/FindKTelepathy.cmake <span style="color: grey">(c9aa9dc)</span></li>
<li>cmake/modules/FindKTp.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/butterfly/CMakeLists.txt <span style="color: grey">(26859c9)</span></li>
<li>plugins/butterfly/kcmtelepathyaccounts_plugin_butterfly.desktop <span style="color: grey">(3df354a)</span></li>
<li>plugins/butterfly/ktpaccountskcm_plugin_butterfly.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/gabble/CMakeLists.txt <span style="color: grey">(81ba67d)</span></li>
<li>plugins/gabble/kcmtelepathyaccounts_plugin_gabble.desktop <span style="color: grey">(62c501c)</span></li>
<li>plugins/gabble/ktpaccountskcm_plugin_gabble.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/haze/CMakeLists.txt <span style="color: grey">(dfedda5)</span></li>
<li>plugins/haze/kcmtelepathyaccounts_plugin_haze.desktop <span style="color: grey">(f044014)</span></li>
<li>plugins/haze/ktpaccountskcm_plugin_haze.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/idle/CMakeLists.txt <span style="color: grey">(3b91531)</span></li>
<li>plugins/idle/kcmtelepathyaccounts_plugin_idle.desktop <span style="color: grey">(adf8078)</span></li>
<li>plugins/idle/ktpaccountskcm_plugin_idle.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/rakia/CMakeLists.txt <span style="color: grey">(bfa8da7)</span></li>
<li>plugins/rakia/kcmtelepathyaccounts_plugin_rakia.desktop <span style="color: grey">(906f1d6)</span></li>
<li>plugins/rakia/ktpaccountskcm_plugin_rakia.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/salut/CMakeLists.txt <span style="color: grey">(80da74f)</span></li>
<li>plugins/salut/kcmtelepathyaccounts_plugin_salut.desktop <span style="color: grey">(98ea8e3)</span></li>
<li>plugins/salut/ktpaccountskcm_plugin_salut.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/sunshine/CMakeLists.txt <span style="color: grey">(0a08d7a)</span></li>
<li>plugins/sunshine/kcmtelepathyaccounts_plugin_sunshine.desktop <span style="color: grey">(aceac75)</span></li>
<li>plugins/sunshine/ktpaccountskcm_plugin_sunshine.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(60542b2)</span></li>
<li>src/KCMTelepathyAccounts/CMakeLists.txt <span style="color: grey">(581edcf)</span></li>
<li>src/KCMTelepathyAccounts/kcmtelepathyaccounts-accountuiplugin.desktop <span style="color: grey">(76ec85c)</span></li>
<li>src/KCMTelepathyAccounts/ktpaccountskcminternal-accountuiplugin.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcm_ktp_accounts.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcm_telepathy_accounts.desktop <span style="color: grey">(cd20e22)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103502/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>