<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103481/">http://git.reviewboard.kde.org/r/103481/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 459d9b48b03a8d649c435a208806c56c213f78d1 by Martin Klapetek to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 20th, 2011, 8:56 p.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Dec. 20, 2011, 8:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This second part moves the actual view out of MainWidget to a separate ContactListWidget class. The separate private class is mainly for the context menu, which needs access to the private variables. The widget should be fully self contained with public slots to change its behaviour/look (switch between groups/accounts, show offline users etc). All error messages are sent out as signals and picked by MainWidget, which displays the actual notifications. All Tp stuff was also moved there.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested all actions. Started chat etc. All works.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279107">279107</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e6d7cea)</span></li>
<li>contact-list-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>contact-list-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>contact-list-widget_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>context-menu.h <span style="color: grey">(178cdf0)</span></li>
<li>context-menu.cpp <span style="color: grey">(fff8c7a)</span></li>
<li>main-widget.h <span style="color: grey">(f01b377)</span></li>
<li>main-widget.cpp <span style="color: grey">(1d3e10c)</span></li>
<li>main-widget.ui <span style="color: grey">(d71a276)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103481/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>