<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103491/">http://git.reviewboard.kde.org/r/103491/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103491/diff/1/?file=44148#file44148line4" style="color: black; font-weight: bold; text-decoration: underline;">KTp/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">set (telepathy_common_internals_private_SRCS</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would also rename these to the name of the target plus _SRCS/_HDRS</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103491/diff/1/?file=44148#file44148line33" style="color: black; font-weight: bold; text-decoration: underline;">KTp/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">33</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">set_target_properties(ktpcommoninternalsprivate PROPERTIES</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Policy now says libKTpX, so this should be KTpCommonInternalsPrivate</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103491/diff/1/?file=44149#file44149line6" style="color: black; font-weight: bold; text-decoration: underline;">KTp/Models/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">set (telepathy_models_private_SRCS</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These too...</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103491/diff/1/?file=44149#file44149line28" style="color: black; font-weight: bold; text-decoration: underline;">KTp/Models/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">kde4_add_library (ktpmodelsprivate SHARED</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KTpModelsPrivate</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103491/diff/1/?file=44166#file44166line25" style="color: black; font-weight: bold; text-decoration: underline;">KTp/circular-countdown.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <KTp/ktp-export.h></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think I've asked again, but I don't remember. Is there a reason this is ktp-export.h instead of the standard <libname>_export.h ? i.e. ktpcommoninternalsprivate_export.h</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103491/diff/1/?file=44182#file44182line27" style="color: black; font-weight: bold; text-decoration: underline;">KTp/wallet-interface.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">using KTp::WalletInterface;</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">const</span> <span class="n">QLatin1String</span> <span class="n">WalletInterface</span><span class="o">::</span><span class="n">s_folderName</span> <span class="o">=</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">"telepathy-kde"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now that's interesting... I guess we can't just change it, as users will lose their passwords... but still, it's ugly.</pre>
</div>
<br />
<p>- George</p>
<br />
<p>On December 21st, 2011, 5:32 p.m., Dario Freddi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dario Freddi.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2011, 5:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As per title.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2476ba7)</span></li>
<li>KTelepathy/CMakeLists.txt <span style="color: grey">(9a92e6d)</span></li>
<li>KTelepathy/Models/CMakeLists.txt <span style="color: grey">(32da52e)</span></li>
<li>KTelepathy/Models/accounts-filter-model.h <span style="color: grey">(9c799b1)</span></li>
<li>KTelepathy/Models/accounts-filter-model.cpp <span style="color: grey">(859c673)</span></li>
<li>KTelepathy/Models/accounts-model-item.h <span style="color: grey">(14692d7)</span></li>
<li>KTelepathy/Models/accounts-model-item.cpp <span style="color: grey">(a057714)</span></li>
<li>KTelepathy/Models/accounts-model.h <span style="color: grey">(09c6c7f)</span></li>
<li>KTelepathy/Models/accounts-model.cpp <span style="color: grey">(c2a78c3)</span></li>
<li>KTelepathy/Models/contact-model-item.h <span style="color: grey">(b22d059)</span></li>
<li>KTelepathy/Models/contact-model-item.cpp <span style="color: grey">(5014568)</span></li>
<li>KTelepathy/Models/groups-model-item.h <span style="color: grey">(c994f3d)</span></li>
<li>KTelepathy/Models/groups-model-item.cpp <span style="color: grey">(9e8f07a)</span></li>
<li>KTelepathy/Models/groups-model.h <span style="color: grey">(e38cbf0)</span></li>
<li>KTelepathy/Models/groups-model.cpp <span style="color: grey">(f576d1c)</span></li>
<li>KTelepathy/Models/proxy-tree-node.h <span style="color: grey">(d6cfb36)</span></li>
<li>KTelepathy/Models/proxy-tree-node.cpp <span style="color: grey">(fb5674b)</span></li>
<li>KTelepathy/Models/tree-node.h <span style="color: grey">(7155b01)</span></li>
<li>KTelepathy/Models/tree-node.cpp <span style="color: grey">(f9413ce)</span></li>
<li>KTelepathy/circular-countdown.h <span style="color: grey">(10f1658)</span></li>
<li>KTelepathy/circular-countdown.cpp <span style="color: grey">(4cbb896)</span></li>
<li>KTelepathy/error-dictionary.h <span style="color: grey">(414fd97)</span></li>
<li>KTelepathy/error-dictionary.cpp <span style="color: grey">(d91bfe5)</span></li>
<li>KTelepathy/global-presence.h <span style="color: grey">(194f8cc)</span></li>
<li>KTelepathy/global-presence.cpp <span style="color: grey">(4fe4407)</span></li>
<li>KTelepathy/ktelepathy-export.h <span style="color: grey">(22bb37e)</span></li>
<li>KTelepathy/presence.h <span style="color: grey">(71e7c6e)</span></li>
<li>KTelepathy/presence.cpp <span style="color: grey">(d291a81)</span></li>
<li>KTelepathy/service-availability-checker.h <span style="color: grey">(c2d7b83)</span></li>
<li>KTelepathy/service-availability-checker.cpp <span style="color: grey">(e1f7e51)</span></li>
<li>KTelepathy/telepathy-handler-application.h <span style="color: grey">(64ab876)</span></li>
<li>KTelepathy/telepathy-handler-application.cpp <span style="color: grey">(2e45c0f)</span></li>
<li>KTelepathy/text-parser.h <span style="color: grey">(aae4672)</span></li>
<li>KTelepathy/text-parser.cpp <span style="color: grey">(dc4c57b)</span></li>
<li>KTelepathy/wallet-interface.h <span style="color: grey">(9c4eb27)</span></li>
<li>KTelepathy/wallet-interface.cpp <span style="color: grey">(6e271fe)</span></li>
<li>KTp/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/accounts-filter-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/accounts-filter-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/accounts-model-item.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/accounts-model-item.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/accounts-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/accounts-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/contact-model-item.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/contact-model-item.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/groups-model-item.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/groups-model-item.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/groups-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/groups-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/proxy-tree-node.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/proxy-tree-node.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/tree-node.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/Models/tree-node.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/circular-countdown.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/circular-countdown.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/error-dictionary.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/error-dictionary.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/global-presence.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/global-presence.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/ktp-export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/presence.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/presence.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/service-availability-checker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/service-availability-checker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/telepathy-handler-application.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/telepathy-handler-application.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/text-parser.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/text-parser.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/wallet-interface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>KTp/wallet-interface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>Messages.sh <span style="color: grey">(615a372)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103491/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>