<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103466/">http://git.reviewboard.kde.org/r/103466/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Dario</p>
<br />
<p>On December 19th, 2011, 11:03 a.m., Daniele Elmo Domenichelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2011, 11:03 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a cumulative patch that fixes a few bugs in the file-transfer handler:
- Save the file as .part and renames the file at the end
- Allows to resume file transfer
- Rename and resume dialogs are modeless
- A few small bugs
- Some cleanup
Sorry if it is a bit messy, but I've being working on all of them at the same time...
Check the branch on my clone repository for single commits:
This is the list of the commits:
450cd114e7181c6b53303ecb8938cfce044d9a88 Unregister jobs when killed
ad2b896874be76276bf49a1fb91f52d7c7947b13 Do not set error when user kills the jobs, set it on file transfer cancelled instead
d29a8b101f44b762d51c86a7fd758f0d4ce8cdda Handle initialOffsetDefined signal
32df541d679670c015c2d4db2acc78fc762a61ff Save url in private class
65c86acf0c56757b84ae6d335c53fb70fb7a5e73 Use .part file while downloading and rename the file at the end
43a1969b8e3cb2a31b82d668a8ce2f4c69bf7137 Make rename dialog modeless and show a dialog to resume file transfer
245be81945c5ea3116749742c9401b9d0f4d4918 Fix processed amount
2872c3f3e672701b32f187301a4445f75f3a8714 Do some cleanup when ft is cancelled
94b572d85c5256bc30481e49e63bf72b6217e08e Unregister jobs later
b765dd12801b4c5295b9e30e994dc633a0fbf259 Register incoming file transfer job only after it is accepted
c961eb8af77d87bce46ed7187916fe0be89a52eb start() and kill() methods no longer need to be asynchronous
f2435bf212def2ec246dfae45f2debeb6c7ebde4 kill() does not need to be asyncronous
378d2d00c7861689e04c8b0edac9ab3bb2a51e98 Show a message if file transfer cannot be resumed
4ee89d37e1f4e849e48c70d8116bdec7a2a7300c Overwrite .part file if user hits cancel on resume file dialog
1287712ab621b435a715b188985c0f062a43a9b4 Normalize signal signature
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Resuming file transfer works
Dialogs are now modeless
There is still some problem with the empty file not deleted sometime, I will fix it later (That's a bug I can fix during the freeze :P )</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=283003">283003</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=283004">283004</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/handle-incoming-file-transfer-channel-job.h <span style="color: grey">(9cc7ad9023e11f002cdd4ed373059e38c754ae3b)</span></li>
<li>src/handle-incoming-file-transfer-channel-job.cpp <span style="color: grey">(0821081d1dbf8948a070fba157c35c5ca26a4fe9)</span></li>
<li>src/handle-outgoing-file-transfer-channel-job.h <span style="color: grey">(f51d53bce0a3968bdbc32c67214e0a9170d995d9)</span></li>
<li>src/handle-outgoing-file-transfer-channel-job.cpp <span style="color: grey">(152c13e706a6b2232f5f9abd6b528df0024f68af)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103466/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>