<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103297/">http://git.reviewboard.kde.org/r/103297/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103297/diff/1/?file=42507#file42507line42" style="color: black; font-weight: bold; text-decoration: underline;">tooltips/ktooltip.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">42</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">static</span> <span class="n">KToolTipManager</span> <span class="o">*</span><span class="n">s_instance</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is bad. If you want to use a singleton, do it right and use K_GLOBAL_STATIC</pre>
</div>
<br />
<p>- Dario</p>
<br />
<p>On December 1st, 2011, 2:34 p.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Dec. 1, 2011, 2:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the result of Google Code-in student Geoffry Song's work, based on David's code (which was stolen from system settings). The tooltips works perfectly, the code is great quality as well, though as it is rather big diff, I'd like to have more eyes on it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've been using it for two days now and all hail to Geoffry, who did really awesome job.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(68dc90c)</span></li>
<li>abstract-contact-delegate.cpp <span style="color: grey">(2bd0f55)</span></li>
<li>main-widget.cpp <span style="color: grey">(7f0adf1)</span></li>
<li>tooltips/contacttooltip.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tooltips/contacttooltip.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tooltips/contacttooltip.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>tooltips/ktooltip.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tooltips/ktooltip.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tooltips/ktooltipwindow.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tooltips/ktooltipwindow_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tooltips/tooltipmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tooltips/tooltipmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103297/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>