<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103302/">http://git.reviewboard.kde.org/r/103302/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the first patch in making it so we don't need to export ContactModelItem, AccountModelItem, TreeNode, ProxyTreeNode, GrouModelItem in our lib.
These classes get in the way of a port to the nepomuk model. The only uses for them is to get to a ContactPtr or AccountPtr, and it involves having to publicly expose a lot of internal classes in our library.
With this done, the code in the Contact List will be a lot less model dependant (as we won't have to proxy through these classes) it will also have a lot smaller and simpler.
This patch
- Adds roles to get a Tp::ContactPtr and Tp::AccountPtr directly.
- Expose a role to return the type of current index (i.e Account, Contact or Group) so we can use that instead of checking the QVariant type on ItemRole.
- Also adds exposure to get the relevant AccountPtr from a contact, rather than having to call an extra method on AccountsModel which again makes code simpler.
- this patch also introduces an asynchronous setting of a Tp::AccountManager on the model. This was needed to fix up the contact-list-applet.
The next step is to rewrite the contact list to not use ItemRole.
ItemRole has not been removed yet, as there is a /lot/ of code to update, so I'm doing it in four phases.
1) Expose the new information we need
2+3) Update everything to use ContactRole/AccountRole (both contact list, and groups-model.cpp need heavy updating)
4) Get rid of the old interface.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTelepathy/Models/accounts-filter-model.cpp <span style="color: grey">(ca7aa91)</span></li>
<li>KTelepathy/Models/accounts-model-item.cpp <span style="color: grey">(db1d98f)</span></li>
<li>KTelepathy/Models/accounts-model.h <span style="color: grey">(12f2438)</span></li>
<li>KTelepathy/Models/accounts-model.cpp <span style="color: grey">(355ee95)</span></li>
<li>KTelepathy/Models/contact-model-item.cpp <span style="color: grey">(d87e21f)</span></li>
<li>KTelepathy/Models/groups-model-item.cpp <span style="color: grey">(9a88788)</span></li>
<li>KTelepathy/Models/groups-model.h <span style="color: grey">(d3cd282)</span></li>
<li>KTelepathy/Models/groups-model.cpp <span style="color: grey">(2827e86)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103302/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>