<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103281/">http://git.reviewboard.kde.org/r/103281/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 28th, 2011, 5:04 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Discussing alternatives, you could also have just done:
[ ]@yahoo.com
and simply placed a label to the right on the text field. It's not a scary warning and is less confusing than changing people's inputs (IMHO)</pre>
</blockquote>
<p>On November 28th, 2011, 5:10 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also possible. Though it changes people input only to what they have to enter anyway. The fact that it changes also displayname is another thing (and should be finally solved as well).</pre>
</blockquote>
<p>On November 28th, 2011, 5:12 p.m., <b>Dario Freddi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">However, quick question. How does that deal with, say, @yahoo.it, and in general any other i18n'ed yahoo website?</pre>
</blockquote>
<p>On November 29th, 2011, 11:13 a.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just checked with @yahoo.de - I can log in using my @yahoo.com credentials for @yahoo.de - martin.klapetek@yahoo.de works, although I've registered only @yahoo.com. So I assume the part after '@' is not really important.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How will you explain this to the users?
Even if it works, if you just leave @yahoo.com people will start complaining that they cannot even enter their address
IMHO if we wanted to show the correct @yahoo.* part the best way is to use a combo box where the @yahoo.com, and the @yahoo.<i18n> will always be the first two entries, but since this part is completely unnecessary we could just do
[ ]@yahoo.* (With an i18n'ed tooltip explaining this *)
And still remove the @yahoo.* part if the user adds it...</pre>
<br />
<p>- Daniele Elmo</p>
<br />
<p>On November 28th, 2011, 1:01 p.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 28, 2011, 1:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Haze requires yahoo! account to be without the @yahoo.com part. This patch removes that part if user adds it. It's imho better to do this than to put a big scary WARNING! above the line edit. Our software appears smart.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Successfully added a yahoo! account and connected.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=287190">287190</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/haze/yahoo-main-options-widget.h <span style="color: grey">(592e582)</span></li>
<li>plugins/haze/yahoo-main-options-widget.cpp <span style="color: grey">(25d163e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103281/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>