<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103117/">http://git.reviewboard.kde.org/r/103117/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good job, the last remarks have been made on IRC, but the code is gold quality indeed. The issue with the magic service string will be solved separately as agreed.</pre>
<br />
<p>- Dario</p>
<br />
<p>On November 14th, 2011, 12:07 p.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Dario Freddi.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 14, 2011, 12:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This tries to automate the setup of salut account. It takes first and last name from KUser, splits them by the last space (the issues have been already discussed) and displays a KMessageWidget (that's why the kdelibs min version bump to 4.7). This auto-closes after 8 secs, displaying a circular countdown. User still has a choice to modify the data by using the dialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3690e31)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(67de5e1)</span></li>
<li>src/kcm-telepathy-accounts.h <span style="color: grey">(1e8d92b)</span></li>
<li>src/kcm-telepathy-accounts.cpp <span style="color: grey">(23420fa)</span></li>
<li>src/main-widget.ui <span style="color: grey">(f333271)</span></li>
<li>src/salut-details-dialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/salut-details-dialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/salut-enable-dialog.h <span style="color: grey">(ca15d59)</span></li>
<li>src/salut-enable-dialog.cpp <span style="color: grey">(d1333a4)</span></li>
<li>src/salut-enabler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/salut-enabler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/salut-message-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/salut-message-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103117/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103117/s/336/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/11/14/salut_12_400x100.png" style="border: 1px black solid;" alt="Salut autoenabler" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>