<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102804/">http://git.reviewboard.kde.org/r/102804/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4e41d798546cff4163fde3e62e09a7d639b88029 by Martin Klapetek to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 10th, 2011, 2:11 p.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Oct. 10, 2011, 2:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Quite a big rewrite of the KDED module. The main changes are:
1/ Use stacking system for plugins
--each plugin has its own priority, if the priority is higher than what's currently in stack, the plugin is placed on top, if it's lower, it's placed below (maintaining the order by priorities)
2/ Plugins now use this sort-of API
--when any plugin wants to set a presence, it signals active(true); which is connected to the module's core where it checks the stack and either uses that plugin's presence or places it somewhere down the stack
3/ Plugins all have common base class
4/ 'Now listening...' aka mpris plugin was gifted with some refactoring as well</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1/ Works
2/ Works
3/ Works too, obviously
4/ Still not with configurable message, but works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(143afef)</span></li>
<li>autoaway.h <span style="color: grey">(a95f49a)</span></li>
<li>autoaway.cpp <span style="color: grey">(812ba97)</span></li>
<li>global-presence.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>global-presence.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>telepathy-kded-module-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>telepathy-kded-module-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>telepathy-module.h <span style="color: grey">(815ee38)</span></li>
<li>telepathy-module.cpp <span style="color: grey">(174cecf)</span></li>
<li>telepathy-mpris.h <span style="color: grey">(5dd596f)</span></li>
<li>telepathy-mpris.cpp <span style="color: grey">(b4920d8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102804/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>