<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102776/">http://git.reviewboard.kde.org/r/102776/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Schmidt.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm sorry this patch got so massive, I spent 4 hours trying to split it up and do a proper review request with no success :-(
Anyways, you can take a look at my branch with more granular commits:
kde:clones/telepathy-text-ui/dschmidt/telepathy-text-ui gomental
Now to the patch:
It adds backlog functionality (currently a hardcoded amount of messages) to the chat widget via telepathy-logger-qt4. I made it an optional dep cause that lib is not released yet and I want to replace it with logs retrieved from Nepomuk for 0.3.
All logic interacting with that lib is encapsulated in the LogManager class, so it will be easy to do that change.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, compiled with -DWITH_TelepathyLoggerQt4=ON and -DWITH_TelepathyLoggerQt4=OFF and both builds work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindGIO.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindGObject.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindQtGLib.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindTelepathyGlib.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindTelepathyLogger.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/FindTelepathyLoggerQt4.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/appearance-config.cpp <span style="color: grey">(895040b)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(801749e)</span></li>
<li>lib/adium-theme-message-info.h <span style="color: grey">(d90112c)</span></li>
<li>lib/adium-theme-message-info.cpp <span style="color: grey">(545444d)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(89879c8)</span></li>
<li>lib/chat-widget.h <span style="color: grey">(0fe5d86)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(302d097)</span></li>
<li>lib/chat-window-style.h <span style="color: grey">(32fe4fd)</span></li>
<li>lib/chat-window-style.cpp <span style="color: grey">(8242d90)</span></li>
<li>lib/logmanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/logmanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102776/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>