<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102668/">http://git.reviewboard.kde.org/r/102668/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and Martin Klapetek.</div>
<div>By George Kiagiadakis.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2011, 7:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improved comment, as David suggested.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a button and a context menu action to every contact in the contact list that allows users to start desktop sharing with the selected contact. The patch also includes a class that checks for the availability of krfb on the system, as there is no way of determining that via telepathy.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Successfully started a desktop sharing session between my laptop and my desktop with krfb. However the client side failed to show the desktop after approving the channel (this is either a bug in krfb - most likely - or something in gabble; I'll inspect it)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(7c463ff50946c4e9b307ed98e41dbf6b4f84a5be)</span></li>
<li>contact-overlays.h <span style="color: grey">(43bcf237397fc2770d834cb29275da17456cf4e2)</span></li>
<li>contact-overlays.cpp <span style="color: grey">(026e3d34b7ceb92e3415a558d15c73293648a2e6)</span></li>
<li>main-widget.h <span style="color: grey">(6843af5af4b0b7d32eccb835793f0a0caec15377)</span></li>
<li>main-widget.cpp <span style="color: grey">(98abf2968bc645f4c78e99806ca264b17e5ccbfc)</span></li>
<li>models/accounts-model.h <span style="color: grey">(40b915b78637dc4d4e2b3d85aa559d4f0b465345)</span></li>
<li>models/accounts-model.cpp <span style="color: grey">(75d224ff2e332bbd3f96293854396d1a28e23ff9)</span></li>
<li>models/contact-model-item.h <span style="color: grey">(cc2a59f713c9de59ecfe95558c7dbed5acf82570)</span></li>
<li>models/contact-model-item.cpp <span style="color: grey">(c32b4ffe6502af074bddd6687a623c2d5673508d)</span></li>
<li>service-availability-checker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>service-availability-checker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102668/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>