<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102636/">http://git.reviewboard.kde.org/r/102636/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>









<p>- David</p>


<br />
<p>On September 16th, 2011, 5:06 p.m., Daniele Elmo Domenichelli wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Telepathy and David Edmundson.</div>
<div>By Daniele Elmo Domenichelli.</div>


<p style="color: grey;"><i>Updated Sept. 16, 2011, 5:06 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use Q_FOREACH instead of foreach


Use Q_EMIT instead of emit


Use Q_SIGNALS instead of signals


Use Q_SLOTS instead of slots</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">builds</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>adiumxtra-protocol-handler/chat-style-installer.cpp <span style="color: grey">(bf3e012c2393c973bf648d102afaa9547ea25717)</span></li>

 <li>adiumxtra-protocol-handler/emoticon-set-installer.cpp <span style="color: grey">(7a7556463cfa641fad731bb733f582fcd1bce2b3)</span></li>

 <li>app/chat-tab.h <span style="color: grey">(9b5fc59b88c233b86956b871499de94594220356)</span></li>

 <li>app/chat-window.h <span style="color: grey">(5288e597fb855dcdbfd001b4928cdad415ef14c4)</span></li>

 <li>app/chat-window.cpp <span style="color: grey">(1ef738fa81b0a1ca38a35252b76293a3f32f8f34)</span></li>

 <li>app/telepathy-chat-ui.h <span style="color: grey">(42f522cc9d26e876fd22d6d7e17f28983df2dabf)</span></li>

 <li>app/telepathy-chat-ui.cpp <span style="color: grey">(b5e99d7b39396357f95d9ebbd971a051b5a561d4)</span></li>

 <li>config/appearance-config.h <span style="color: grey">(64029554807b76201170eca60158760e9c649966)</span></li>

 <li>config/behavior-config.h <span style="color: grey">(dd8cc3dd9ff34d080de4050c9db5b59f1f50d694)</span></li>

 <li>lib/adium-theme-view.h <span style="color: grey">(0507128d585346a4556d247bb83de4e13105b2cb)</span></li>

 <li>lib/channel-contact-model.h <span style="color: grey">(d0c2cb5e06ebe0dc52c2d9e9e2563c8e937c8fb6)</span></li>

 <li>lib/channel-contact-model.cpp <span style="color: grey">(7887880ac9736b1769c5493c93d350b02067ef26)</span></li>

 <li>lib/chat-search-bar.h <span style="color: grey">(daf909f7c1d6456e65c269d5df4cd19a1435cacb)</span></li>

 <li>lib/chat-search-bar.cpp <span style="color: grey">(0659f93765c1fac69bc3e3806d36a332021eeef5)</span></li>

 <li>lib/chat-text-edit.h <span style="color: grey">(c643db21b76b259269fd9227fc3139325d69ba5e)</span></li>

 <li>lib/chat-text-edit.cpp <span style="color: grey">(1086e476f4371ec0e3b1e410a13b7a1860a472bb)</span></li>

 <li>lib/chat-widget.h <span style="color: grey">(7f4376422131231ce7f2502ce3d47142a4aed8fd)</span></li>

 <li>lib/chat-widget.cpp <span style="color: grey">(2e0d9b1b3b2c37d56a151202f6eb68ee0c145e49)</span></li>

 <li>lib/chat-window-style-manager.h <span style="color: grey">(21efa90c318120877180ea7edcecbbbb6a99096f)</span></li>

 <li>lib/chat-window-style-manager.cpp <span style="color: grey">(815d6f255d4ea5e49b8b8f333d071cb774a8c39b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102636/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>