<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101636/">http://git.reviewboard.kde.org/r/101636/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b9f6aabe54fcca2ce4a19dbc4029e9c693d73076 by George Goldberg to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 20th, 2011, 2:05 p.m., George Goldberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By George Goldberg.</div>
<p style="color: grey;"><i>Updated July 20, 2011, 2:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch massively tidies up Contact/Person/PersonSetModel classes, which are the basic classes needed for the Nepomuk enabled contact list port to get underway. All the basic readonly properties are now fully functional, with all short-term FIXME's dealt with.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests still pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/contact.h <span style="color: grey">(026a7361a35556a261a1ad10910bf846b024bd64)</span></li>
<li>src/core/contact.cpp <span style="color: grey">(c91058a261fe4f79dd505d97f901401c09ba53b4)</span></li>
<li>src/core/person.h <span style="color: grey">(eb017da98d8a01a8555ef3568f095bf2cfe74109)</span></li>
<li>src/core/person.cpp <span style="color: grey">(4269789b0d45838024901907d728b058ae17e8de)</span></li>
<li>src/ui/person-set-model.h <span style="color: grey">(95416fff218ad568149ad453f692a9fcdfa635b2)</span></li>
<li>src/ui/person-set-model.cpp <span style="color: grey">(7a5849af208d7596171ebb8c95adcf488135d73d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101636/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>