<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101545/">http://git.reviewboard.kde.org/r/101545/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 1119e91395b4d161d6030de138b1aa137940f113 by George Goldberg.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 8th, 2011, 3:23 p.m., George Goldberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By George Goldberg.</div>
<p style="color: grey;"><i>Updated June 8, 2011, 3:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch reinstates the PersonSetModel - the main part of the telepathy-kde UI components that is useful to the ContactList. It is a trivial port to tpqt4 >= 0.5 and also reinstates the unit test for this class and makes it work with current telepathy-testlib.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests all pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(54478d18c86d2aea915a1abe24cd4c4cfd2d3ca7)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(da55c6372faac35ce72a9780fb2c0977bdd2a84e)</span></li>
<li>tests/person-set-model-test.h <span style="color: grey">(debbcac9d50351175afba339417eec2e426bacc3)</span></li>
<li>tests/person-set-model-test.cpp <span style="color: grey">(9da86360a8cdcea7d37b884f3c1bf0d6f9ff5939)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101545/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>