<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101488/">http://git.reviewboard.kde.org/r/101488/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d9d6c7cfa54bffc0996844244d712ea0d82c74b1 by Martin Klapetek.</pre>
<br />
<p>- Commit</p>
<br />
<p>On June 1st, 2011, 10:59 p.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated June 1, 2011, 10:59 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As suggested by oggis, the account->becomeReady() is useless there --
<oggis_> void MainWidget::onNewAccountAdded(const Tp::AccountPtr& account)
<oggis_> { Tp::PendingReady *ready = account->becomeReady();
<oggis_> why, although you have an account factory with a lot of features including FeatureCore set up for the account manager?
<oggis_> that means that any account signaled to you using newAccount will have becomeReady with those features already called
<oggis_> (and finished)
<oggis_> that's your AccountManager::newAccount handler
<oggis_> in which you're calling becomeReady(), which means "give me an operation which emits finished() when Account::FeatureCore is ready on the account"
<oggis_> although by passing Account::FeatureCore in the factory, you already say to the library "prepare FeatureCore for all accounts before signaling them to me in the first place"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Everything works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>main-widget.h <span style="color: grey">(96f228e)</span></li>
<li>main-widget.cpp <span style="color: grey">(4b6c248)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101488/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>