<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101441/">http://git.reviewboard.kde.org/r/101441/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 30th, 2011, 10:40 a.m., <b>Dario Freddi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The changes are fine - I simply do not understand why you are disabling all the streamtubes job. Any particular reason for that?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because they still need porting to tpqt4 0.5 - I'm doing it one part at a time, so disabled them from building until they are ported in a later patch :)</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 30th, 2011, 10:40 a.m., <b>Dario Freddi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101441/diff/2/?file=18076#file18076line6" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">set(KDE_MIN_VERSION "4.<span class="hl">4.75</span>")</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">set(KDE_MIN_VERSION "4.<span class="hl">6.60</span>")</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this intended? Any special reason for bumping the requirement to KDE 4.7 here?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, this code won't work with any older nepomuk versions.</pre>
<br />
<p>- George</p>
<br />
<p>On May 26th, 2011, 3:31 p.m., George Goldberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By George Goldberg.</div>
<p style="color: grey;"><i>Updated May 26, 2011, 3:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch ports the "core" of the telepathy-kde library to current tpqt4/nepomuk/kde versions. Those parts of the library that are ported should now be 100% functional (and all the unit tests currently pass for me). This does not include the KJobs and UI components - these are to come in a later patch once this one has been merged (they are commented out in the build scripts for now).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All unit tests pass for me.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a9b19c4924df10ccc45c1e86506394248b6adb75)</span></li>
<li>cmake/modules/FindTelepathyQt4.cmake <span style="color: grey">(14b568b99218e9883e1da691aa2057aa110cdd10)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(937aee6ad004d957810e870461b6fd503c5ec589)</span></li>
<li>src/core/contact.cpp <span style="color: grey">(1402511b889757a19fb1499b1924b7d39fb8387b)</span></li>
<li>src/core/everyone-person-set.cpp <span style="color: grey">(04163cb855e1a981121c1b1fefabad4533ec83f5)</span></li>
<li>src/core/people-manager.cpp <span style="color: grey">(7d70aafa3e1882c742d2928545b9bf54a0c3c749)</span></li>
<li>src/core/person.cpp <span style="color: grey">(c6ee0d4be594b811885377fd483bcf2b959f7d16)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(e2e7cc260bbc8ba0a21127da84f15f5d473a29b8)</span></li>
<li>tests/entity-test.h <span style="color: grey">(52ac4d28eaa06518d7cb20e2c4f6d0f72696c757)</span></li>
<li>tests/entity-test.cpp <span style="color: grey">(82b5f390dd4a1586d95a553e6678292f3cc15f03)</span></li>
<li>tests/everyone-person-set-test.h <span style="color: grey">(1189db863c5c777d62d6824a0fad5ecf6d3eb2f4)</span></li>
<li>tests/everyone-person-set-test.cpp <span style="color: grey">(817600e1b1ccb1a2f4a03851c2e45689e5bd9fe4)</span></li>
<li>tests/people-manager-test.h <span style="color: grey">(c643bbd34b1a43ceb111bdcb60643e86d56258cf)</span></li>
<li>tests/people-manager-test.cpp <span style="color: grey">(c530c15100392168296997b40591bf197a27e447)</span></li>
<li>tests/person-set-test.h <span style="color: grey">(21b0a3ae5718c4a073a4b6bd4814debcad42ee72)</span></li>
<li>tests/person-set-test.cpp <span style="color: grey">(e04b763f0f0086a22b16e03169b36afa5f730204)</span></li>
<li>tests/simple-person-set-test.h <span style="color: grey">(eaecda9b44acb22269d51f1268b4385613e4186b)</span></li>
<li>tests/simple-person-set-test.cpp <span style="color: grey">(a57f8515e2939dc33d0e74e2fd38ab0905ecf4a0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101441/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>