<br><br><div class="gmail_quote">On Sun, May 29, 2011 at 11:34 AM, Francesco Nwokeka <span dir="ltr"><<a href="mailto:francesco.nwokeka@gmail.com">francesco.nwokeka@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi fellow devs,<br>
I'm writing to talk about the telepathy-approver. What does it do in it's current state? For<br>
what I know, the approver just handles incoming text chats. Well that's a too little job for my<br>
taste.</blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
So what I propose is to make it a deamon that handles common things between the kde-telepathy<br>
components. These "common" things may be for example the kde-tp -> system notifications comunication.<br></blockquote><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Right now the contact list and chat handler both have this integrated in their code. Why write the<br>
same code twice when we could write it once and use the approver for it so that both contactlist and<br>
chat handler handle more important stuff?<br></blockquote><div><br></div><div>That's not actually true. There is no duplicate code in the contact list and chat handler for notifications. Also the chat handler /has/ to do the notifications itself as it contains logic to work out if the chat is visible or not.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Doing things this way will let other components take advantage of what the approver has to offer.<br>
<br></blockquote><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
What do you guys think about this?<br></blockquote><div><br></div><div>With the problem "we need a central place to handle account notifications"</div><div>I agree 100%</div><div><br></div><div>We need something to handle</div>
<div> - Accounts going offline / not connecting </div><div> - Contacts adding you (properly)</div><div> - Misc tasks such as setting the status to "away" if the screensaver starts, or "busy" if the screensaver is disabled (i.e clearly watching a movie or a presentation)</div>
<div> - Setting status to currently playing song.</div><div><br></div><div>With the solution "therefore it should go in the approver":</div><div> I disagree completely. The approver should be doing just it's one task. Putting other tasks in it both complicates the code and goes against the modular nature. It stops us having switchable approvers.</div>
<div><br></div><div>I talked with martin about making a "kded" clone, for all the little KDE-TP jobs. I think this is a slightly stronger plan. </div><div><br></div><div>I also don't think this is a release 1 issue.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Francesco<br>
_______________________________________________<br>
KDE-Telepathy mailing list<br>
<a href="mailto:KDE-Telepathy@kde.org">KDE-Telepathy@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-telepathy" target="_blank">https://mail.kde.org/mailman/listinfo/kde-telepathy</a><br>
</blockquote></div><br>