<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101380/">http://git.reviewboard.kde.org/r/101380/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101380/diff/4/?file=16643#file16643line168" style="color: black; font-weight: bold; text-decoration: underline;">account-filter-model.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void AccountFilterModel::printDebug(QModelIndex tl, QModelIndex br)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">168</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//FIXME FIXME FIXME -- this is an ugly workaround for some filter-misbehaving issues, need to investigate</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've opened a bug report on this, as I don't want it to get forgotten. https://bugs.kde.org/show_bug.cgi?id=273725
(might be worth changing the method name to something less obscure. or connecting dataChanged() directly to invalidate)
I don't think it's a bug in your groups model, as I see the same behaviour with accountsModel and the FlatModelProxy. I think AccountsModel may be at fault.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On May 18th, 2011, 4:14 p.m., Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated May 18, 2011, 4:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds cross-account groups to contact list.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with several accounts with groups, also tried moving contacts between groups from another client. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(919df77)</span></li>
<li>account-filter-model.h <span style="color: grey">(6591355)</span></li>
<li>account-filter-model.cpp <span style="color: grey">(75f2126)</span></li>
<li>contact-delegate.cpp <span style="color: grey">(209e715)</span></li>
<li>groups-model-item.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>groups-model-item.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>groups-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>groups-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>main-widget.h <span style="color: grey">(7a5e417)</span></li>
<li>main-widget.cpp <span style="color: grey">(20e8003)</span></li>
<li>proxy-tree-node.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>proxy-tree-node.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>telepathy-kde-contactlist.notifyrc <span style="color: grey">(918736e)</span></li>
<li>tree-node.h <span style="color: grey">(adeefa4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101380/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>