<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100689/">http://git.reviewboard.kde.org/r/100689/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems ok to me. 

There&#39;s one thing to sort out with git first (editing the yahoo options) before pushing.</pre>
 <br />





<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/100689/diff/4/?file=15567#file15567line70" style="color: black; font-weight: bold; text-decoration: underline;">haze/haze-account-ui-plugin.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">HazeAccountUiPlugin::HazeAccountUiPlugin(QObject *parent, const QVariantList &amp;)</pre></td>

  </tr>
 </tbody>






 
 

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">66</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="p">}</span></pre></td>
    <th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">69</font></th>
    <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">                <span class="p">}</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure if this is just reviewboard showing it wrong, but check this bracket is in the right place.</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/100689/diff/4/?file=15570#file15570line32" style="color: black; font-weight: bold; text-decoration: underline;">haze/yahoo-main-options-widget.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 4)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>

  </tr>
 </tbody>





 
 


 <tbody>

  <tr>
    <th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th>
    <td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">foreach</span> <span class="p">(</span><span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">ProtocolParameter</span> <span class="o">&amp;</span><span class="n">param</span><span class="p">,</span> <span class="n">model</span><span class="o">-&gt;</span><span class="n">parameters</span><span class="p">())</span> <span class="p">{</span></pre></td>
    <th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">don&#39;t edit yahoo-main-options-widget when adding yours!</pre>
</div>
<br />



<p>- David</p>


<br />
<p>On April 28th, 2011, 2:46 p.m., Lasath Fernando wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Lasath Fernando.</div>


<p style="color: grey;"><i>Updated April 28, 2011, 2:46 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I created a AIM plugin, with basic and advanced options in one go this time.

It&#39;s in my personal clone
http://quickgit.kde.org/?p=clones/telepathy-accounts-kcm-plugins/fernando/main.git&amp;a=shortlog&amp;h=refs/heads/aol-plugin-build

(branch called &#39;aol-plugin-build&#39;)</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Edited options and made sure they were reflected in Empathy.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>haze/CMakeLists.txt <span style="color: grey">(a998a65)</span></li>

 <li>haze/aim-main-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>haze/aim-main-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>haze/aim-main-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>haze/aim-server-settings-widget.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>haze/aim-server-settings-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>haze/aim-server-settings-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>haze/haze-account-ui-plugin.cpp <span style="color: grey">(4854636)</span></li>

 <li>haze/haze-aim-account.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>haze/haze-aim-account.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>haze/yahoo-main-options-widget.cpp <span style="color: grey">(108a023)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100689/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>