<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101179/">http://git.reviewboard.kde.org/r/101179/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 22nd, 2011, 5:06 p.m., <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101179/diff/2/?file=15099#file15099line5" style="color: black; font-weight: bold; text-decoration: underline;">contact-model-item.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">5</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Copyright (C) 2010 Collabora Ltd. <<span class="hl">http://www.</span>collabora.co.uk<span class="hl">/</span>></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">5</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * Copyright (C) 2010 Collabora Ltd. <<span class="hl">info@</span>collabora.co.uk></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We should probably also unify the email address format..</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As discussed on IRC, I'll unmangle all mangled addresses before pushing</pre>
<br />
<p>- Dario</p>
<br />
<p>On April 22nd, 2011, 2:04 p.m., Dario Freddi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dario Freddi.</div>
<p style="color: grey;"><i>Updated April 22, 2011, 2:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Decently sized branch with lots of misc fixes and stuff. Will let git cherry explain that for me:
+ 4b5c54c7705f474aeb2b7da9eecb2f42b139aeb2 Expand only the item belonging to the account which is being connected - and collapse it upon disconnection
+ 75249599c256084302249327cc9b6b2789698a80 Cast properly: never use static_cast unless strictly required, and use qobject_cast wherever possible
+ a7431ac2081d74d4b08502483ea64240c76fe688 Includes done right: own include must always go first, moc should go to the bottom - and remember a newline at the end of the file
+ eaf348e97578fdca27cc3b78c6556f45d795f537 Always use deleteLater() on QObject except some special cases, and beware: connect() can crash if the sender is null as well.
+ f392c5d0e215f6e693166d7677948859396c9010 Add missing copyrights
+ b7b5052275d0740bda5eb87aaaaf8600d0f0eab8 AbstractWidgetDelegateOverlay: Make m_widget a QWeakPointer. Given that we strongly rely on having m_widget == 0 on deletion, just use the proper method.
+ 4a630c51036d5c47558a6561fe828b7ed456632c Remove unneeded signal handlers
+ 2dcd374ce0518570d184b2791ee53b70bc326c00 Use proper copyright tags: email instead of web address
+ f3b388bda7ed34273d8c954529b0bd2be51ab319 Fix misuse of i18n, add some context to some calls
+ 9604b357205618a2302cbff2211ed1f24012ad29 Make constructors explicit when needed
+ 4e7ef1ef7b79da894cff4a63c6f622197e86542e Fix typo
+ 8d975a87648a4fd996bd9f83113040ddbcafb2b3 Use K* classes
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Apparently, compiles and works</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>account-button.h <span style="color: grey">(451af7e1af9a3a70557416ffb7c8d301fb9ec10b)</span></li>
<li>account-button.cpp <span style="color: grey">(db00d7bd6b19a15425757052bc788d1b4232e51e)</span></li>
<li>account-filter-model.cpp <span style="color: grey">(8ca65612b67eec4a9dff4791ac6ff591738ea019)</span></li>
<li>accounts-model-item.h <span style="color: grey">(1f99064c60da09a4a2c4ac7b750db14c460f9d63)</span></li>
<li>accounts-model-item.cpp <span style="color: grey">(33e44671e89fbca27c11b8713240442ea36ff2c6)</span></li>
<li>accounts-model.h <span style="color: grey">(42cc2b24e580838448fb0fae865540f3f54cc802)</span></li>
<li>accounts-model.cpp <span style="color: grey">(366c46fc8b765c56b31709e535758991f1d9e329)</span></li>
<li>add-contact-dialog.h <span style="color: grey">(c9bfbd0f4bd03dc67854a3f09c2388048f5431b3)</span></li>
<li>add-contact-dialog.cpp <span style="color: grey">(6dd32d2ff568b8d30bf9276ae39605e2a0dc5cf4)</span></li>
<li>add-contact-dialog.ui <span style="color: grey">(637537d5da93db069f167c5bf0be63e589757ef6)</span></li>
<li>contact-delegate-overlay.h <span style="color: grey">(5c5e29546aa0b988a79684084eede7e409317553)</span></li>
<li>contact-delegate-overlay.cpp <span style="color: grey">(d56b36d979d2f3c7221fbc13cd47ec6730580f37)</span></li>
<li>contact-delegate.h <span style="color: grey">(2a3703d5335a9424bfcded5cc97eec701f08a56c)</span></li>
<li>contact-delegate.cpp <span style="color: grey">(705f80053f1e524cb62cfe092fe7637f47d35b0f)</span></li>
<li>contact-model-item.h <span style="color: grey">(eceb054f480e1df60d6b2ae8fd8e355645cab525)</span></li>
<li>contact-model-item.cpp <span style="color: grey">(e77b8edceedd529c3365fa83455f09b3858f2853)</span></li>
<li>contact-overlays.cpp <span style="color: grey">(0869ef801866039397ab2db591e83dc35696b229)</span></li>
<li>contact-view-hover-button.h <span style="color: grey">(a3e8a9d1461cf8b28a0fd643b80cd27ad015a6c7)</span></li>
<li>contact-view-hover-button.cpp <span style="color: grey">(d6bde9e96f95de46c6bbdfece4e8178e8d57d645)</span></li>
<li>main-widget.cpp <span style="color: grey">(a100c0505f094611261d08a159332df7b89d8b6e)</span></li>
<li>main.cpp <span style="color: grey">(ddc5fedc888c64bb2b39dd27d6bc03da0121bfc3)</span></li>
<li>remove-contact-dialog.h <span style="color: grey">(2af624a31986d52595a80a26b2505e77a4271791)</span></li>
<li>remove-contact-dialog.cpp <span style="color: grey">(e6c6a8620d1acfc0701d051e7a5d2d881251dfea)</span></li>
<li>tree-node.h <span style="color: grey">(c800621b1674015402fdceaa0c0e50a899f8facd)</span></li>
<li>tree-node.cpp <span style="color: grey">(804f4392ca0790e5c011fa27d07be715ef679621)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101179/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>