<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101080/">http://git.reviewboard.kde.org/r/101080/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 14th, 2011, 10:21 a.m., <b>Rohan Garg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Correct me if I am wrong, but won't it be better to use KProtocolInfo::isKnownProtocol here instead of doing things manually</pre>
</blockquote>
<p>On April 14th, 2011, 10:30 a.m., <b>Francesco Nwokeka</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Where?if you refer to line 365 then that's not possible. The url is "hidden" inside a blob of html code. That means I have to search for the url patterns and send it to the chat as a link otherwise it's not recognized.</pre>
</blockquote>
<p>On April 14th, 2011, 10:50 a.m., <b>Rohan Garg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah okay, KProtocolInfo can also provide you with a list of known protocols, maybe that can be used and used along.with the regex?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That list would give me a list of protocols known to my system. Whilst links passed in a chat are web-based. This is what KProtocolInfo::protocols() returns on my system
("rtsp", "mmst", "tomahawk", "mmsu", "sftp", "imaps", "zip", "skype", "mbox", "ms-its", "pnm", "timeline", "itpc", "data", "mms", "adiumxtra", "help", "videodvd", "nepomuk", "aim", "sieve", "finger", "lastfm", "metainfo", "bzip", "desktop", "fish", "bookmarks", "floppy", "nfs", "webcal", "lzma", "info", "filenamesearch", "irc6", "webdav", "ftp", "nntp", "nepomuksearch", "tar", "file", "pop3s", "applications", "network", "http", "ldaps", "ghelp", "amarok", "settings", "xz", "xmpp", "gzip", "audiocd", "rtspt", "rtspu", "man", "fonts", "ar", "feed", "trash", "smtp", "imap", "bzip2", "smb", "akonadi", "https", "webdavs", "cgi", "tel", "nntps", "irc", "callto", "pop3", "programs", "about", "thumbnail", "smtps", "ldap", "remote")
So I don't think that'd be useful</pre>
<br />
<p>- Francesco</p>
<br />
<p>On April 14th, 2011, 9:38 a.m., Francesco Nwokeka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Francesco Nwokeka.</div>
<p style="color: grey;"><i>Updated April 14, 2011, 9:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simple patch to recognize other links other than http(s). Added smb and (s)ftp. if there are others to add please let me know</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=270345">270345</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/adium-theme-view.cpp <span style="color: grey">(8a8818c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101080/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>