<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101121/">http://git.reviewboard.kde.org/r/101121/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/101121/diff/1/?file=14382#file14382line118" style="color: black; font-weight: bold; text-decoration: underline;">main-widget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">MainWidget::MainWidget(QWidget *parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">117</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_actionAdd_contact</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">setIc</span>on</span><span class="p">(</span><span class="n">KIcon</span><span class="p">(</span><span class="s">"list-add-user"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">118</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_actionAdd_contact</span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="k"><span class="hl">new</span></span><span class="hl"> </span><span class="n"><span class="hl">KActi</span>on</span><span class="p">(</span><span class="n">KIcon</span><span class="p">(</span><span class="s">"list-add-user"</span><span class="p">)<span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">i18n</span></span><span class="p"><span class="hl">(</span></span><span class="s"><span class="hl">"Add contact"</span></span><span class="p"><span class="hl">),</span></span><span class="hl"> </span><span class="k"><span class="hl">this</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">118</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_actionAdd_contact</span><span class="o">-></span><span class="n">setText</span><span class="p">(</span><span class="n">QString</span><span class="p">());</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">119</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_actionAdd_contact</span><span class="o">-></span><span class="n">setText</span><span class="p">(</span><span class="n">QString</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wonder why on all actions you define a text in the constructor and then you call setText(QString()). What's the point of that?</pre>
</div>
<br />
<p>- George</p>
<br />
<p>On April 14th, 2011, 1:28 p.m., Nicolas Lécureuil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Nicolas Lécureuil.</div>
<p style="color: grey;"><i>Updated April 14, 2011, 1:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch remove the QActions from the ui file and add them on the cpp file to allow us to use KAction and KStandardShortcut and thus use the standard KDE shortcuts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested with standard shortcut ( Ctrl +F ) + changed the shortcut in systemsettings and retested in telepathy-contact-list to see that it was using new shortcut ( Ctrl + J ) for my test.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>main-widget.h <span style="color: grey">(18f97ee)</span></li>
<li>main-widget.cpp <span style="color: grey">(7fe200c)</span></li>
<li>main-widget.ui <span style="color: grey">(d000b9b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101121/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>