<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100979/">http://git.reviewboard.kde.org/r/100979/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- David</p>
<br />
<p>On March 31st, 2011, 10:55 a.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated March 31, 2011, 10:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes font family and size configureable. It currently uses two methods to achieve this:
* Set the default font for the QWebView
* Add some extra css to make the user setting actually do something in case the theme does hardcode the font-family in it's css files and does not use relative font sizes.
As noted on the code, this patch also includes a check whether the default font requested by the theme is installed on the user's system which for now lacks a warning which should be shown to the user.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">installed some themes, seems to work. the css approach for sure needs to be improved since just altering html div elements won't do the trick for all themes.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=265704">265704</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>config/chatwindowconfig.ui <span style="color: grey">(a24b789c6c40fa665cefbbfa997997cda970e1c4)</span></li>
<li>config/main-window.h <span style="color: grey">(1eb2030653f4702de934b1f47c383aff7cc8e556)</span></li>
<li>config/main-window.cpp <span style="color: grey">(d74de0b87d98585ea3314597b7a9401ae8fd4eb9)</span></li>
<li>lib/adium-theme-view.h <span style="color: grey">(920e06208ea7f6cef23054c4a1ddf52ed02aa420)</span></li>
<li>lib/adium-theme-view.cpp <span style="color: grey">(b7a88f850de1f71e453f99b11dc98642dc18ccb0)</span></li>
<li>lib/chat-window-style.h <span style="color: grey">(3ca12a8a00b406ba0bf79af4ec4baab86d853ba5)</span></li>
<li>lib/chat-window-style.cpp <span style="color: grey">(33f6c35f6e7539e14718dd563eab9c6966210632)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100979/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100979/s/110/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/03/30/text-ui-config-default-font_400x100.png" style="border: 1px black solid;" alt="default (in this case fallback) font" /></a>
<a href="http://git.reviewboard.kde.org/r/100979/s/111/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/03/30/text-ui-config-custom-font_400x100.png" style="border: 1px black solid;" alt="custom font" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>