<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100972/">http://git.reviewboard.kde.org/r/100972/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is definitely a strange situation, and I will have a better look. If the superclass is under our control, the approach I'd choose is to have both implicitly shared, and have the private data pointer to be privately inherited by the subclass, which would somehow make the situation more sustainable. But for now, this change is definitely fine.</pre>
<br />
<p>- Dario</p>
<br />
<p>On March 30th, 2011, 8:51 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 30, 2011, 8:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes a bug in which calls to
AdiumThemeMessageInfo a = someOtherMessageInfo class failed to actually copy all the information.
This appears a bug in the config window as found by Florian Reinhard: https://git.reviewboard.kde.org/r/100922/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/adium-theme-content-info.cpp <span style="color: grey">(a5e1d6780ccf65acd70a024648955f621457eb65)</span></li>
<li>lib/adium-theme-status-info.cpp <span style="color: grey">(b2568e05a534f8d59bb82220043d9ff0dfb88aff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100972/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>