<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100455/">http://git.reviewboard.kde.org/r/100455/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As the change has not been marked as submitted (do so if it has been), nitpicking on some small things</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100455/diff/4/?file=12831#file12831line50" style="color: black; font-weight: bold; text-decoration: underline;">src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class AbstractAccountParametersWidget::Private</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">50</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QMap</span><span class="o"><</span><span class="n">QPersistentModelIndex</span><span class="p">,</span><span class="n">ValidatedLineEdit</span><span class="o">*></span> <span class="n">validatedWidgets</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you do not need ordered values (like it appears to be in this case), use QHash instead of QMap - it is slightly faster.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100455/diff/4/?file=12831#file12831line129" style="color: black; font-weight: bold; text-decoration: underline;">src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void AbstractAccountParametersWidget::handleParameter(const QString &parameterName,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span><span class="n">validated</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code style: if (</pre>
</div>
<br />
<p>- Dario</p>
<br />
<p>On March 24th, 2011, 8:18 p.m., Thomas Richard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Thomas Richard.</div>
<p style="color: grey;"><i>Updated March 24, 2011, 8:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch will give some visible feedback in a non obtrusive way. There is also the possibility to provide some custom validation on parameters using the ParameterEditModel.
The screenshots speak a 1000 words ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When all parameters are valid, an account still gets added</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KCMTelepathyAccounts/CMakeLists.txt <span style="color: grey">(51389226299db38012f7f326b3e57709f4d3e244)</span></li>
<li>src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp <span style="color: grey">(9f5b0d4f9b27c0502783895ee0f52e320829ffc3)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.h <span style="color: grey">(11d80778e4ed0fc7f80943d2248d3f08b27feb20)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.cpp <span style="color: grey">(5c09e5dade33ae383d63827add757c8688c24fb7)</span></li>
<li>src/KCMTelepathyAccounts/feedback-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/feedback-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/include/ValidatedLineEdit <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.h <span style="color: grey">(d904facc2c958440d193fe86182bd50c0ee6721f)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.cpp <span style="color: grey">(441b6e58daf13b3fcf65ab344544ae36e50b940b)</span></li>
<li>src/KCMTelepathyAccounts/validated-line-edit.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/validated-line-edit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/add-account-assistant.h <span style="color: grey">(973bad46e11697135c331c632e9cb63dcb790232)</span></li>
<li>src/add-account-assistant.cpp <span style="color: grey">(eb9a644d38b0020ce3158c99f3714dddd1b8047a)</span></li>
<li>src/edit-account-dialog.cpp <span style="color: grey">(bcfaca26ec9fbf8385b4d43d2c673319c8bdc9a9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100455/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100455/s/56/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/28/validation1_400x100.png" style="border: 1px black solid;" alt="Valid email address" /></a>
<a href="http://git.reviewboard.kde.org/r/100455/s/57/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/28/validation2_400x100.png" style="border: 1px black solid;" alt="Invalid email address" /></a>
<a href="http://git.reviewboard.kde.org/r/100455/s/58/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/28/validation3_400x100.png" style="border: 1px black solid;" alt="Invalid email address and clicking apply" /></a>
<a href="http://git.reviewboard.kde.org/r/100455/s/59/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/28/validation4_400x100.png" style="border: 1px black solid;" alt="When an account did not get accepted by telepathy itself" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>