<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100970/">http://git.reviewboard.kde.org/r/100970/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First of all, awesome job on this one. A pair of comments follow</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100970/diff/2/?file=13352#file13352line1" style="color: black; font-weight: bold; text-decoration: underline;">cmake/modules/FindGIO.cmake</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># - Try to find the GIO libraries</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As per KDE policy, we should copyright those files under a BSD license (have a look in kdelibs/cmake/modules). If you copy-pasted this from tp-qt4, feel free to assign the copyright to me, otherwise I guess you wrote it, and eternal glory should be yours :)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100970/diff/2/?file=13354#file13354line148" style="color: black; font-weight: bold; text-decoration: underline;">lib/glib/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">148</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">install (FILES ${tp_glib_tests_INSTALL_HDRS}</pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">149</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> DESTINATION ${INCLUDE_INSTALL_DIR}/KTelepathy/TestLib/GLib</pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">150</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> COMPONENT Devel</pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">151</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">)</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I actually don't like that - why are we installing headers for the glib library? Ideally in the test library we should try and handle tp-glib internally, and expose high-level methods. I don't know if this is meant as a temporary workaround or it has become compulsory for some things you want to do.</pre>
</div>
<br />
<p>- Dario</p>
<br />
<p>On March 29th, 2011, 8:06 p.m., George Goldberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By George Goldberg.</div>
<p style="color: grey;"><i>Updated March 29, 2011, 8:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Resync the glib CM's with upstream and make sure everything still builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stuff builds :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(24e033ad6162196f207c0211c69ccf869f7f1b51)</span></li>
<li>cmake/modules/FindGIO.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/KTelepathyTestLibConfig.cmake.in <span style="color: grey">(fb358e0402c4c51e13ae7fedea95d458a40810ba)</span></li>
<li>lib/glib/CMakeLists.txt <span style="color: grey">(85249502c690e3ff8ed3c5ec64bdc49aa20e07f5)</span></li>
<li>lib/glib/bug-19101-conn.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/bug-19101-conn.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/bug16307-conn.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/bug16307-conn.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/contacts-conn.h <span style="color: grey">(39e87fbb84d973d88f4170d6254efc009568736d)</span></li>
<li>lib/glib/contacts-conn.c <span style="color: grey">(47997dba87d91dbdcd1387e8048a6401c659acb2)</span></li>
<li>lib/glib/echo-chan.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/echo-chan.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/echo-cm.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/echo-cm.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/echo-conn.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/echo-conn.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/echo-im-manager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/echo-im-manager.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/myassert.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/params-cm.c <span style="color: grey">(a0b1820cffcbb744d47decb4e0afa7f4a06b1aee)</span></li>
<li>lib/glib/simple-account.c <span style="color: grey">(2674f71bbbdc0e31c94c4bf73bd3915473ef5f73)</span></li>
<li>lib/glib/simple-channel-dispatcher.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/simple-channel-dispatcher.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/simple-channel-request.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/simple-channel-request.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/simple-conn.h <span style="color: grey">(12204dda0dd8c44f47c1da31ec72f36ed4c75767)</span></li>
<li>lib/glib/simple-conn.c <span style="color: grey">(1c981896555198c4f60bae784b06e836fadff23e)</span></li>
<li>lib/glib/simple-manager.h <span style="color: grey">(2edf213944a850c1a55b1f8a4b641019ed0f15b3)</span></li>
<li>lib/glib/simple-manager.c <span style="color: grey">(d1592cfca2a582f52605b83319465a9cf0c5846f)</span></li>
<li>lib/glib/stream-tube-chan.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/stream-tube-chan.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/stub-object.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/stub-object.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/glib/textchan-group.h <span style="color: grey">(61e1c0c66d6bf00333bf6134b43ecd295e42bbb3)</span></li>
<li>lib/glib/textchan-group.c <span style="color: grey">(6a6f5d7f3d11a4f982d1e37e831f1720cb7e5a89)</span></li>
<li>lib/glib/textchan-null.h <span style="color: grey">(163dec68d4617d4070e3a702eb80ca388eaa9263)</span></li>
<li>lib/glib/textchan-null.c <span style="color: grey">(48857f95874c5ea0c6ebf044d050b0bdaa2a91dd)</span></li>
<li>lib/glib/util.h <span style="color: grey">(d3433ccf9c108dbd57391ebd7ac5c0a5d76872c3)</span></li>
<li>lib/glib/util.c <span style="color: grey">(4dbec7bb28b7b317862c3be6896c4edc774781bd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100970/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>