<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100687/">http://git.reviewboard.kde.org/r/100687/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 30th, 2011, 1:29 p.m., <b>Dario Freddi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this change still pending review? If not, please mark the review as submitted or discarded, else I'll have a look</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nobody has reviewed it, but I am not waiting for it to be reviewed, since there is nobody that can fully review all aspects of it. So, I will merge it anyway when I get back to work, but if you wish to have a quick look, please go ahead; this can only be a good thing.</pre>
<br />
<p>- George</p>
<br />
<p>On February 19th, 2011, 10:20 p.m., George Kiagiadakis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By George Kiagiadakis.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2011, 10:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a complete refactoring of libtelepathy-kde-call, the library that handles audio/video streaming using telepathy-farstream.
The new design is based on the new Call.DRAFT spec and telepathy-farstream, which are way cleaner than their predecessors, StreamedMediaChannel and telepathy-farsight. This inherently makes the design of this library cleaner too. In addition to this, the GStreamer sources and sinks have also been redesigned to handle correctly possible race conditions (i.e. do correct synchronization between the main thread and the gstreamer streaming threads and also between telepathy-qt4 and telepathy-glib) and also allow dynamic switching of source devices.
http://quickgit.kde.org/?p=clones/telepathy-call-ui/gkiagia/telepathy-call-ui.git&a=shortlog&h=refs/heads/call-2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have successfully done audio calls with call-ui <-> empathy and call-ui <-> echo bot, using a modified version of the GUI that will be in another review request later, once it is completed. Video calls and some other features are not tested, as the GUI still needs some work to support them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(59582bfa98fd738e50a5efbb39d03802e9f0e25c)</span></li>
<li>libqtf/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>libqtf/qtf.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libqtf/qtf.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/CMakeLists.txt <span style="color: grey">(d6a39b8d182f457909a78bf9a02a0d0efbf1aceb)</span></li>
<li>libtelepathy-kde-call/callchannelhandler.h <span style="color: grey">(94c27c18a1c37f590232acd9c9a77a969f85bedd)</span></li>
<li>libtelepathy-kde-call/callchannelhandler.cpp <span style="color: grey">(05aeff6040bb741a61b08ff1520e002487903406)</span></li>
<li>libtelepathy-kde-call/callchannelhandler_p.h <span style="color: grey">(5a1ce85bee81ef0e3c088e22845537e9c60c62f0)</span></li>
<li>libtelepathy-kde-call/callcontenthandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/callcontenthandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/callcontenthandler_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/callparticipant.h <span style="color: grey">(5ac2ad7d69e5465f18f25de0c86b8333ee632af3)</span></li>
<li>libtelepathy-kde-call/callparticipant.cpp <span style="color: grey">(9a683935d1212262671b6bab071b179b70dacb5b)</span></li>
<li>libtelepathy-kde-call/sinkcontrollers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/sinkcontrollers.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/sinkcontrollers_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/sourcecontrollers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/sourcecontrollers.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/sourcecontrollers_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/tests/sourcetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/volumecontroller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libtelepathy-kde-call/volumecontroller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100687/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>