<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100968/">http://git.reviewboard.kde.org/r/100968/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, ship it on the condition that you address the other comments in another patch.
Also could you post to the ML about your plans for the plasmoid. It seems to be gaining some extra functionality, so it would be good to share your ideas with the group first.</pre>
<br />
<p>- David</p>
<br />
<p>On March 29th, 2011, 2:29 p.m., Dario Freddi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dario Freddi.</div>
<p style="color: grey;"><i>Updated March 29, 2011, 2:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch ports the data engine to Telepathy Qt4 0.5.x, and adds new Service operations for setting avatars and nicknames. It also enhances data retrieval and fixes some small bugs here and there.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Engine explorer works flawlessly</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(409c6135e53ecee63f02a756a9c0d8c5c399fe4e)</span></li>
<li>plasma-dataengine-presence.desktop <span style="color: grey">(7a850af570113882b1d8c3509e3c260a2fc77353)</span></li>
<li>presence.h <span style="color: grey">(eb5d6dac20a9e7469508d4b87bb7fd02a5624c24)</span></li>
<li>presence.cpp <span style="color: grey">(179c8055bbf29bd17eb80faf8fd14a8549a453a9)</span></li>
<li>presence.operations <span style="color: grey">(0aed15758af9cab6780bd8b31822ce991d045983)</span></li>
<li>presenceservice.cpp <span style="color: grey">(d7a9a64d3b04acbb5ae19c9b7194c2f47efae74c)</span></li>
<li>presencesource.h <span style="color: grey">(586b70f258d7b9bd0bc239aba25b599a038cfd4a)</span></li>
<li>presencesource.cpp <span style="color: grey">(fdab2c400e8833844c7feed71d77927acd9160cf)</span></li>
<li>setavatarjob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>setavatarjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>setnicknamejob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>setnicknamejob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>setrequestedpresencejob.h <span style="color: grey">(40c2ca1f5abff5d82c49f9ac1019b162e9249128)</span></li>
<li>setrequestedpresencejob.cpp <span style="color: grey">(0a77a48941ab41cebe59b6646ba5bbde796ad7a4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100968/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>