<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100940/">http://git.reviewboard.kde.org/r/100940/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100940/diff/1/?file=12799#file12799line75" style="color: black; font-weight: bold; text-decoration: underline;">lib/channel-contact-model.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QVariant ChannelContactModel::data(const QModelIndex &index, int role) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">75</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">QVariant</span><span class="p">(</span><span class="n">KIcon</span><span class="p">(</span><span class="s">"im-user"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the default icon should be different than the same as for online presence, because if Tp can't get the presence type, there might be just something wrong with this user. I've experienced it in contact list - I have a user among my contacts, which has been invited, but haven't actually used that account, Tp then returns an unknown presence for this user. Therefore I suggest to use a different icon, for example the small yellow triangle with excl.mark to indicate that there is something wrong with this user. </pre>
</div>
<br />
<p>- Martin</p>
<br />
<p>On March 24th, 2011, 2:58 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 24, 2011, 2:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If there are more than 1 other contact in a group chat show a list of these users in a sidebar.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opened a chat, saw that some people were there.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/CMakeLists.txt <span style="color: grey">(5dc3f74aede922597ced7a7a2229fa141b3372ea)</span></li>
<li>lib/channel-contact-list.h <span style="color: grey">(37f29e6305c96a1aa9f3a30a2eabb141139f33f5)</span></li>
<li>lib/channel-contact-list.cpp <span style="color: grey">(2eccee0a852e47d90a74a518adcc9260e1c8cef7)</span></li>
<li>lib/channel-contact-model.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/channel-contact-model.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>lib/chat-widget.cpp <span style="color: grey">(6ea639b0b3696030bd76bba219522abf70aef400)</span></li>
<li>lib/chat-widget.ui <span style="color: grey">(173e1151bf04c8573525ff193adffb7129df808a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100940/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>