<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100776/">http://git.reviewboard.kde.org/r/100776/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Very minor comments.
Also if making visual changes - it's worth including a screenshot like you did on some other reviews.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100776/diff/1/?file=10387#file10387line30" style="color: black; font-weight: bold; text-decoration: underline;">haze/haze-myspaceim-account-ui.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <KCMTelepathyAccounts/parameter-edit-model.h></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should be
<KCMTelepathyAccounts/ParameterEditModel>
also where possible try and group the includes, so that all the KCMTelepathy ones are together.
In fact - if it's only used for debugging - consider taking it (and the debugging 57-59) out.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100776/diff/1/?file=10390#file10390line48" style="color: black; font-weight: bold; text-decoration: underline;">haze/myspaceim-advanced-settings-widget.ui</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">48</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <number>65536</number></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should be 65535.
Source: Google for maximum port number
</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On March 7th, 2011, 5:21 p.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated March 7, 2011, 5:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add MySpaceIM (myspace) support to haze plugin.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* add account
* connect
note: if you create a new account from scratch, you need to use pidgin to set your username, telepathy-haze does not support this atm.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>haze/myspaceim-main-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/myspaceim-main-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/myspaceim-main-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/myspaceim-advanced-settings-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/myspaceim-advanced-settings-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/myspaceim-advanced-settings-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/haze-myspaceim-account-ui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/haze-myspaceim-account-ui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/haze-account-ui-plugin.cpp <span style="color: grey">(0bc48fd294ad9ef5cb45a3dbb311649723ba0465)</span></li>
<li>haze/CMakeLists.txt <span style="color: grey">(96476e72ca62efcce3933031b4400e2bc7070a72)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100776/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>