<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100689/">http://git.reviewboard.kde.org/r/100689/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Lasath Fernando.</div>
<p style="color: grey;"><i>Updated March 5, 2011, 8:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, most of the issues appear to be fixed (either by freinhard when he wrote the skype plugin, or you when you fixed my conflicts :)
I removed the debugging code to print out a list of supported parameters from both my plugins. If I have time I'd like to add it to the constructor of AbstractAccountParametersWidget, as it was rather useful.
I pushed the changes back to my clone, this time in branch aim.
http://quickgit.kde.org/?p=clones/telepathy-accounts-kcm-plugins/fernando/main.git&a=shortlog&h=refs/heads/aim</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I created a AIM plugin, with basic and advanced options in one go this time.
It's in my personal clone
http://quickgit.kde.org/?p=clones/telepathy-accounts-kcm-plugins/fernando/main.git&a=shortlog&h=refs/heads/aol-plugin-build
(branch called 'aol-plugin-build')</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Edited options and made sure they were reflected in Empathy.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>haze/aim-main-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>haze/yahoo-main-options-widget.cpp <span style="color: grey">(8beec3c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100689/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>