<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100777/">http://git.reviewboard.kde.org/r/100777/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 2nd, 2011, 12:54 a.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That looked simple :-)
Does it work when you remove an account "normally" through the accounts KCM?
The way I read this it will call onAccountRemoved and then emit removed(), but the Tp::Account will also be emitting removed anyway, which means account-item will emit removed()
(if that makes sense)
Because of this I think remove() will get emitted twice.
Try taking out line 167 of account-item.cpp and it should all behave nicely.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well spotted!
Removing an account via the kcmshell4 looks like it should on commanline:
09:38:13 kcmshell(11417) KCMTelepathyAccounts::onRemoveAccountClicked:
09:38:14 kcmshell(11417) AccountsListModel::removeAccount:
09:38:14 kcmshell(11417) AccountItem::remove: Account about to be removed
09:38:15 kcmshell(11417) AccountsListModel::onAccountItemRemoved:
09:38:15 kcmshell(11417) KWidgetItemDelegateEventListener::eventFilter: User of KWidgetItemDelegate should not delete widgets created by createItemWidgets!
09:38:15 kcmshell(11417) AccountItem::~AccountItem:
with a removed Q_EMIT removed(); in onAccountRemoved it looks like this:
09:48:47 kcmshell(12432) KCMTelepathyAccounts::onRemoveAccountClicked:
09:48:48 kcmshell(12432) AccountsListModel::removeAccount:
09:48:48 kcmshell(12432) AccountItem::remove: Account about to be removed
09:48:49 kcmshell(12432) AccountsListModel::onAccountItemRemoved:
09:48:49 kcmshell(12432) KWidgetItemDelegateEventListener::eventFilter: User of KWidgetItemDelegate should not delete widgets created by createItemWidgets!
09:48:49 kcmshell(12432) AccountItem::~AccountItem:
looks pretty much the same to me, that's why i didn't bother. but emitting the signal twice isn't a good practice so i guess it should be removed.</pre>
<br />
<p>- Florian</p>
<br />
<p>On March 1st, 2011, 9:21 p.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated March 1, 2011, 9:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove an account from the list as it gets removed by some other app like empathy.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* open the kcm module and empathy
* remove an account in empathy and see it being deleted from the kcm</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/account-item.cpp <span style="color: grey">(20709790b89bc79780371b7823462d00815db05c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100777/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>