<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100693/">http://git.reviewboard.kde.org/r/100693/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 22nd, 2011, 5:25 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td><a href="/r/100693/s/78/" style="color: black; font-weight: bold; font-size: 9pt;">telepathy_sunshine.png</a></td>
</tr>
<tr>
<td><a href="http://git.reviewboard.kde.org/r/100693/s/78/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/20/telepathy_sunshine_426_139_191_71.png" style="border: 1px black solid;" alt="Main and Advanced Settings"></a></td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You don't need labels if you're using QCheckbox, the text on the right is sufficient.
Also I (as a user) don't understand what S(SSL) is. Is it just SSL?
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, youre right here, the strings were broken.
Labels for checkboxes are inspired by a blogpost by Aurélien, see (bottom)
http://agateau.wordpress.com/2010/12/27/common-user-interface-mistakes-in-kde-applications-part-2-dialog-layouts/</pre>
<br />
<p>- Florian</p>
<br />
<p>On February 27th, 2011, 2:47 p.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2011, 2:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a plugin for the telepathy-sunshine connection manager which provides gadu-gadu support.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* add account
* change account
* delete account
* check the above in empathy
* connect
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sunshine/sunshine-main-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>sunshine/sunshine-main-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sunshine/sunshine-main-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sunshine/sunshine-advanced-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sunshine/sunshine-advanced-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>sunshine/sunshine-advanced-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sunshine/sunshine-account-ui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sunshine/sunshine-account-ui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sunshine/sunshine-account-ui-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sunshine/sunshine-account-ui-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(af2208973bc096cb4c572fa807adbcd79250a3bd)</span></li>
<li>sunshine/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>sunshine/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>sunshine/kcmtelepathyaccounts_plugin_sunshine.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100693/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100693/s/78/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/20/telepathy_sunshine_400x100.png" style="border: 1px black solid;" alt="Main and Advanced Settings" /></a>
<a href="http://git.reviewboard.kde.org/r/100693/s/86/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/27/telepathy_sunshine2_400x100.png" style="border: 1px black solid;" alt="New strings for advanced->misc-settings" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>