<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100693/">http://git.reviewboard.kde.org/r/100693/</a>
     </td>
    </tr>
   </table>
   <br />









<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/100693/diff/2/?file=9626#file9626line37" style="color: black; font-weight: bold; text-decoration: underline;">sunshine/sunshine-account-ui-plugin.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">SunshineAccountUiPlugin::SunshineAccountUiPlugin(QObject *parent, const QVariantList &amp;)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">37</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">registerProvidedProtocol</span><span class="p">(</span><span class="s">&quot;sunshine&quot;</span><span class="p">,</span> <span class="s">&quot;gadugadu&quot;</span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Have these been updated to use QLatin1String?</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://git.reviewboard.kde.org/r/100693/diff/2/?file=9626#file9626line52" style="color: black; font-weight: bold; text-decoration: underline;">sunshine/sunshine-account-ui-plugin.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">SunshineAccountUiPlugin::SunshineAccountUiPlugin(QObject *parent, const QVariantList &amp;)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="k">if</span><span class="p">((</span><span class="n">connectionManager</span> <span class="o">==</span> <span class="s">&quot;sunshine&quot;</span><span class="p">)</span> <span class="o">&amp;&amp;</span> <span class="p">(</span><span class="n">protocol</span> <span class="o">==</span> <span class="s">&quot;gadugadu&quot;</span><span class="p">))</span> <span class="p">{</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QLatin1String</pre>
</div>
<br />



<p>- David</p>


<br />
<p>On February 20th, 2011, 6:47 p.m., Florian Reinhard wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>


<p style="color: grey;"><i>Updated Feb. 20, 2011, 6:47 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a plugin for the telepathy-sunshine connection manager which provides gadu-gadu support.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* add account
* change account
* delete account
* check the above in empathy
* connect

</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(f7fa03d)</span></li>

 <li>sunshine/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sunshine/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sunshine/kcmtelepathyaccounts_plugin_sunshine.desktop <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sunshine/sunshine-account-ui-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sunshine/sunshine-account-ui-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sunshine/sunshine-account-ui.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sunshine/sunshine-account-ui.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sunshine/sunshine-advanced-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sunshine/sunshine-advanced-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sunshine/sunshine-advanced-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sunshine/sunshine-main-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sunshine/sunshine-main-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>sunshine/sunshine-main-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100693/diff/" style="margin-left: 3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/100693/s/78/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/20/telepathy_sunshine_400x100.png" style="border: 1px black solid;" alt="Main and Advanced Settings" /></a>

</div>


  </td>
 </tr>
</table>








  </div>
 </body>
</html>