<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100712/">http://git.reviewboard.kde.org/r/100712/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 21st, 2011, 11:28 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100712/diff/2/?file=9825#file9825line56" style="color: black; font-weight: bold; text-decoration: underline;">salut/salut-account-ui-plugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">AbstractAccountUi* SalutAccountUiPlugin::accountUi(const QString &connectionManager,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">(</span><span class="n">serviceName</span> <span class="o">==</span> <span class="s">"local_xmpp"</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't understand the part:
or serviceName == "local_xmpp"
No other protocol should have a profile called local_xmpp, and if it did it could be a completely different set of options that should go to a different UI plugin.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">serviceName == "local_xmpp" was a left over because of a tp-qt4 bug which left connectionManager and protocol blank and just filled serviceName.
note: to use the plugin posted here you need tp-qt4 with this patch
http://git.collabora.co.uk/?p=user/andrunko/telepathy-qt4.git;a=commit;h=2ded0365e60a61387d1212103b164965d6c94424</pre>
<br />
<p>- Florian</p>
<br />
<p>On February 21st, 2011, 11:05 p.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2011, 11:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add plugin for the salute connection manager which provides bonjour.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">add account in empathy
edit in kcm
adding in kcm is currently not possible, is about to be fixed by David Edmundsen.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f7fa03d93f0ba3fb460df9ab3342cb9e75bbe792)</span></li>
<li>salut/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/kcmtelepathyaccounts_plugin_salut.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-account-ui-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-account-ui-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-account-ui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-account-ui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-advanced-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-advanced-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-advanced-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-main-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-main-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-main-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100712/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100712/s/81/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/21/telepathy-salut_400x100.png" style="border: 1px black solid;" alt="Main and Advanced Options" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>