<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100712/">http://git.reviewboard.kde.org/r/100712/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 21st, 2011, 11:33 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td><a href="/r/100712/s/81/" style="color: black; font-weight: bold; font-size: 9pt;">telepathy-salut.png</a></td>
</tr>
<tr>
<td><a href="http://git.reviewboard.kde.org/r/100712/s/81/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/21/telepathy-salut_161_248_32_85.png" style="border: 1px black solid;" alt="Main and Advanced Options"></a></td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">More of an opinion than a fully qualified review comment:
Do we need to use a GroupWidget?
domme would certainly get annoyed at the double margin.
a simple QLabel/KTitleWidget at the top might be a better alternative.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No we don't need to use a GroupWidget here but they just look good. Since eye candy is usually appreciated by users (and me), i did it that way ;)
With the changes to the general handling of advanced options being worked on atm, i guess the UI will be worked on later anyways.</pre>
<br />
<p>- Florian</p>
<br />
<p>On February 21st, 2011, 11:05 p.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2011, 11:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add plugin for the salute connection manager which provides bonjour.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">add account in empathy
edit in kcm
adding in kcm is currently not possible, is about to be fixed by David Edmundsen.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f7fa03d93f0ba3fb460df9ab3342cb9e75bbe792)</span></li>
<li>salut/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/kcmtelepathyaccounts_plugin_salut.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-account-ui-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-account-ui-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-account-ui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-account-ui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-advanced-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-advanced-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-advanced-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-main-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-main-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>salut/salut-main-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100712/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100712/s/81/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/02/21/telepathy-salut_400x100.png" style="border: 1px black solid;" alt="Main and Advanced Options" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>