<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100581/">http://git.reviewboard.kde.org/r/100581/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100581/diff/1/?file=8481#file8481line392" style="color: black; font-weight: bold; text-decoration: underline;">lib/chatwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ChatWidget::notifyAboutIncomingMessage(const Tp::ReceivedMessage & message)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">307</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">notification</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">activated</span><span class="p">(</span><span class="kt">unsigned</span> <span class="kt">int</span><span class="p">)),</span> <span class="n">notification</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">raiseWidget</span><span class="p">()));</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">390</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">notification</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">activated</span><span class="p">(</span><span class="kt">unsigned</span> <span class="kt">int</span><span class="p">)),</span> <span class="n">notification</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">raiseWidget</span><span class="p">()));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This can be removed probably?!</pre>
</div>
<br />
<p>- Dominik</p>
<br />
<p>On February 5th, 2011, 8:34 p.m., Dominik Schmidt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Schmidt.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2011, 8:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Most important change: show colors on the tabs.
P.S.: Ignore the config/-dir, i will clean this up before pushing, just want a first comment on what i did for the colors</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested it, but please tell me the smallest glitch you find. Those I know of:
- on status change the chatview doesn't scroll down
- no decent default size on the first startup of the chatwindow</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chatwindow.cpp <span style="color: grey">(5cf2ea0)</span></li>
<li>app/chatwindow.h <span style="color: grey">(e6e2ffd)</span></li>
<li>adiumxtra-protocol-handler/CMakeLists.txt <span style="color: grey">(514aa87)</span></li>
<li>app/CMakeLists.txt <span style="color: grey">(738a3b6)</span></li>
<li>app/main.cpp <span style="color: grey">(06281e2)</span></li>
<li>app/telepathychatui.h <span style="color: grey">(1cfe76c)</span></li>
<li>app/telepathychatui.cpp <span style="color: grey">(4415c82)</span></li>
<li>config/CMakeLists.txt <span style="color: grey">(6d1e900)</span></li>
<li>config/chatwindowconfig.ui <span style="color: grey">(bd3faf2)</span></li>
<li>config/kcm-telepathy-chat.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/kcm-telepathy-chat.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/kcm_telepathy_chat.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>config/main.cpp <span style="color: grey">(03f5633)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(f4e46aa)</span></li>
<li>lib/chatwidget.h <span style="color: grey">(c4b3945)</span></li>
<li>lib/chatwidget.cpp <span style="color: grey">(a559adc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100581/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>