<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100461/">http://git.reviewboard.kde.org/r/100461/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100461/diff/1/?file=8019#file8019line482" style="color: black; font-weight: bold; text-decoration: underline;">lib/chatwindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ChatWindow::onContactAliasChanged(const Tp::ContactPtr & contact, const QString& alias)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">478</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">statusMessage</span><span class="p">.</span><span class="n">setStatus</span><span class="p">(</span><span class="n">QString</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no point setting "status" to an empty string, it defaults to that.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On January 30th, 2011, 10:07 p.m., George Kiagiadakis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy and David Edmundson.</div>
<div>By George Kiagiadakis.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2011, 10:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">shortlog:
George Kiagiadakis (5):
Fix the contactPresenceChanged signal to actually notify us about presence changes.
Let mainwindow know the correct chat window icon from the beggining of the session.
Fix the presence change messages.
Catch contact alias changes.
Do not show notifications about messages that have already been shown by the approver.
http://quickgit.kde.org/?p=clones/telepathy-chat-handler/gkiagia/telepathy-chat-handler.git&a=shortlog&h=refs/heads/fixes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All changes have been tested, except the remote contact's alias change.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/mainwindow.cpp <span style="color: grey">(98647c9cbf3bd3456c9fc79ab8acb048dad393e0)</span></li>
<li>lib/channelcontactlist.h <span style="color: grey">(f3fae069081febf3c5471bd8b74708f1ec72ec93)</span></li>
<li>lib/channelcontactlist.cpp <span style="color: grey">(499ae802d10990179a3f3c97d0f09639024df0b2)</span></li>
<li>lib/chatwindow.h <span style="color: grey">(434ece2946daeace4b93fafb14a8a67aa718e4c0)</span></li>
<li>lib/chatwindow.cpp <span style="color: grey">(92e7a5329f6a1ed00634aa28ce6dfe3590ace6a5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100461/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>