<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100455/">http://git.reviewboard.kde.org/r/100455/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Thomas Richard.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2011, 5:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement suggestions of George
Don't put the validation state in the model every keystroke. Do it after we updated the actual values in the model as that makes more sense.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch will give some visible feedback in a non obtrusive way. There is also the possibility to provide some custom validation on parameters using the ParameterEditModel.
The screenshots speak a 1000 words ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When all parameters are valid, an account still gets added</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KCMTelepathyAccounts/CMakeLists.txt <span style="color: grey">(51389226299db38012f7f326b3e57709f4d3e244)</span></li>
<li>src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp <span style="color: grey">(9f5b0d4f9b27c0502783895ee0f52e320829ffc3)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.h <span style="color: grey">(11d80778e4ed0fc7f80943d2248d3f08b27feb20)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.cpp <span style="color: grey">(5c09e5dade33ae383d63827add757c8688c24fb7)</span></li>
<li>src/KCMTelepathyAccounts/feedback-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/feedback-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/include/ValidatedLineEdit <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.h <span style="color: grey">(d904facc2c958440d193fe86182bd50c0ee6721f)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.cpp <span style="color: grey">(441b6e58daf13b3fcf65ab344544ae36e50b940b)</span></li>
<li>src/KCMTelepathyAccounts/validated-line-edit.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/validated-line-edit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/add-account-assistant.h <span style="color: grey">(973bad46e11697135c331c632e9cb63dcb790232)</span></li>
<li>src/add-account-assistant.cpp <span style="color: grey">(eb9a644d38b0020ce3158c99f3714dddd1b8047a)</span></li>
<li>src/edit-account-dialog.cpp <span style="color: grey">(bcfaca26ec9fbf8385b4d43d2c673319c8bdc9a9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100455/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100455/s/56/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/28/validation1_400x100.png" style="border: 1px black solid;" alt="Valid email address" /></a>
<a href="http://git.reviewboard.kde.org/r/100455/s/57/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/28/validation2_400x100.png" style="border: 1px black solid;" alt="Invalid email address" /></a>
<a href="http://git.reviewboard.kde.org/r/100455/s/58/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/28/validation3_400x100.png" style="border: 1px black solid;" alt="Invalid email address and clicking apply" /></a>
<a href="http://git.reviewboard.kde.org/r/100455/s/59/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/28/validation4_400x100.png" style="border: 1px black solid;" alt="When an account did not get accepted by telepathy itself" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>