<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100444/">http://git.reviewboard.kde.org/r/100444/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 26th, 2011, 5:03 p.m., <b>Thomas Richard</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100444/diff/1/?file=7573#file7573line59" style="color: black; font-weight: bold; text-decoration: underline;">sofiasip/sofiasip-main-options-widget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">SofiaSIPMainOptionsWidget::SofiaSIPMainOptionsWidget(ParameterEditModel *model,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">59</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">ui</span><span class="o">-></span><span class="n">accountLineEdit</span><span class="o">-></span><span class="n">text</span><span class="p">()</span> <span class="o">==</span> <span class="s">""</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code style:
if(condition) {
...
}</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if (d->ui->accoutLineEdit->text().isEmpty() ) {
is better here.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 26th, 2011, 5:03 p.m., <b>Thomas Richard</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100444/diff/1/?file=7573#file7573line70" style="color: black; font-weight: bold; text-decoration: underline;">sofiasip/sofiasip-main-options-widget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">SofiaSIPMainOptionsWidget::SofiaSIPMainOptionsWidget(ParameterEditModel *model,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">70</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">delete</span> <span class="n">d</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You should delete d->ui too</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">before you delete d!</pre>
<br />
<p>- David</p>
<br />
<p>On January 26th, 2011, 4:48 p.m., Florian Reinhard wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Florian Reinhard.</div>
<p style="color: grey;"><i>Updated Jan. 26, 2011, 4:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the following telepathy-sofiasip parameters are implemented:
account
password
alias
stun-server
stun-port
discover-stun
discover-binding
loose-routing
keepalive-mechanism
keepalive-interval
these are missing atm:
proxy-host
port
transport
registrar
immutable-streams
local-ip-address
local-port
extra-auth-user
extra-auth-password
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">add new account
edit existing account
connect</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9aec0ecf2243e302d3cd01f1c4bd246f6e248305)</span></li>
<li>sofiasip/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>sofiasip/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>sofiasip/kcmtelepathyaccounts_plugin_sofiasip.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>sofiasip/sofiasip-account-ui-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sofiasip/sofiasip-account-ui-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sofiasip/sofiasip-account-ui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sofiasip/sofiasip-account-ui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sofiasip/sofiasip-advanced-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sofiasip/sofiasip-advanced-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sofiasip/sofiasip-advanced-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>sofiasip/sofiasip-main-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>sofiasip/sofiasip-main-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>sofiasip/sofiasip-main-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100444/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100444/s/55/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/01/26/telepathy_sofiasip_400x100.png" style="border: 1px black solid;" alt="Main Options and Advanced Options" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>