<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100376/">http://git.reviewboard.kde.org/r/100376/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Dominik Schmidt.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This got a little huge, I'm sorry.
This patch refactors the way plugins work.
It uses (kind of) the methods from the last review request but additionally uses the QDataWidgetMapper as suggested (and partly implemented) by Thomas - please tell me your mail address!
Also it avoids passing around ParameterLists and Values and instead passes the ParameterEditModel through all levels.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, works for me for adding and editing accounts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KCMTelepathyAccounts/CMakeLists.txt <span style="color: grey">(082f3352c4e5855d87b594620e7e317160b557c1)</span></li>
<li>src/KCMTelepathyAccounts/abstract-account-parameters-widget.h <span style="color: grey">(44bba673ee0479f7253e6c2ac0860888362d0642)</span></li>
<li>src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp <span style="color: grey">(d0ad71a3660ed2514817a67e6fd2a283481b54d9)</span></li>
<li>src/KCMTelepathyAccounts/abstract-account-ui.h <span style="color: grey">(a90395ca4e429fa37ccf935f19fcd0063397d4e9)</span></li>
<li>src/KCMTelepathyAccounts/abstract-account-ui.cpp <span style="color: grey">(a2a09c0485e2eec5e64c96a91ddaddea2747e68d)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.h <span style="color: grey">(9e8ac689eb15d7666a3be06f98af5a67703efd6c)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.cpp <span style="color: grey">(d78cf93fbd9bb905ef2b382e07b0ac780f2f9e3b)</span></li>
<li>src/KCMTelepathyAccounts/generic-advanced-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/generic-advanced-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/include/GenericAdvancedOptionsWidget <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/include/ParameterEditModel <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.h <span style="color: grey">(4eac5a7512c8e0a1f90f7d570f69d0659b61c2b6)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.cpp <span style="color: grey">(a30481ef12ef11533aab26b3200c94eb50139f49)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-widget.h <span style="color: grey">(566cbe1227adb7e0bd7ee4637f1263273f83333b)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-widget.cpp <span style="color: grey">(7dd1e530d167a860564200351dea5ae3cd00f9a8)</span></li>
<li>src/KCMTelepathyAccounts/parameter-item.cpp <span style="color: grey">(8f907f7988b10d0e58f5beddf04ebedd54fdfb00)</span></li>
<li>src/add-account-assistant.cpp <span style="color: grey">(184cf93ef8c7b1df944c3fb54cde8f5b6749cec2)</span></li>
<li>src/edit-account-dialog.cpp <span style="color: grey">(45ec8407f943da77175d6f320fe13b92b75874f1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100376/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>