<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100337/">http://git.reviewboard.kde.org/r/100337/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Lasse Liehu.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2011, 5:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure, I didn't check code I copied from butterfly plugin.
Tp::ProtocolParameterList -> const Tp::ProtocolParameterList &parameters where possible (not for mainOptionsWidget and advancedOptionsWidget), also some whitespace fixes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A way to select an IRC network from a set of presets isn't yet done. Does Telepathy give anything here?
Also there isn't any hint for the user what "Username" means. I'm still wondering if it being empty means "use current local system username as one" or "use nick as one" and a set value to use that value as one. I guess it should default to empty anyhow. Empathy doesn't seem to use the parameter in any way.
There isn't an error message shown if parameter validation fails, but it wouldn't even show if someone does "Enable/Disable the "next" (or finish button) depending on whether required parameters are filled in." (as at http://community.kde.org/index.php?title=Real-Time_Communication_and_Collaboration/Components/Accounts_KCM_Tasks ).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles and the plugin loads.
Tested creating and editing an account. All supported parameters load and save correctly and Empathy can use the created account.
Validation (just testing if server and nick are non-empty) works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4a102d94a28c5ac927039ed63acc10c08b490ad4)</span></li>
<li>butterfly/main-options-widget.ui <span style="color: grey">(36496c9d152b88b4490ee137e9bcbcf83a0ee573)</span></li>
<li>idle/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>idle/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>idle/advanced-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>idle/advanced-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>idle/advanced-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>idle/idle-account-ui-plugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>idle/idle-account-ui-plugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>idle/idle-account-ui.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>idle/idle-account-ui.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>idle/kcmtelepathyaccounts_plugin_idle.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>idle/main-options-widget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>idle/main-options-widget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>idle/main-options-widget.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100337/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>