<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100293/">http://git.reviewboard.kde.org/r/100293/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated 2011-01-05 21:38:20.070349</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reverted behaviour to not save any parameter which is the same as the protocol default. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Compile against Telepathy-Qt4 0.5
Changed account abstract-account-parameters-widget.h to return
QVariantMap of parameterValues() instead of trying to
QMap<ParameterItem,QString> which didn't compile.
There didn't appear to be a reason for doing this as it was just copied
to a QVariantMap directly after anyway.
Note that the code now doesn't remove any parameters which have the same
value as the default. This didn't seem to be a step required by
Telepathy.
Also updated parameter-edit-model to always return the value in the type
requested by the ProtocolParameter.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checked it now compiled
Added an account, edited an account and removed an account. Account adding and editing done using both the UI plugins and the generic configuration.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KCMTelepathyAccounts/CMakeLists.txt <span style="color: grey">(a74ae27c89e1ad9e0ad6948bf959f4c93bd1ab7c)</span></li>
<li>src/KCMTelepathyAccounts/abstract-account-parameters-widget.h <span style="color: grey">(6357b4eaff3b5579b44d9040ffe33314bbf09d80)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.h <span style="color: grey">(4c78338603dc0b88230b52190ca9d373dff2628d)</span></li>
<li>src/KCMTelepathyAccounts/account-edit-widget.cpp <span style="color: grey">(b554db71a17a4c9664d04f781561ce62cbc17562)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.h <span style="color: grey">(0c762ea5a30253cd1c4b772f3859b681f4fa8dd4)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-model.cpp <span style="color: grey">(0fe52a10798b03dff5491d78c1b16ad72e2f0533)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-widget.h <span style="color: grey">(4d3b5a62735bd519ce01f39037dad151e6b34cb3)</span></li>
<li>src/KCMTelepathyAccounts/parameter-edit-widget.cpp <span style="color: grey">(187c39fbf990b610b8985d1869d48bc2be7c9c6d)</span></li>
<li>src/KCMTelepathyAccounts/parameter-item.h <span style="color: grey">(14b11160204a5b76ee3b0fed65861d0ceec87a7f)</span></li>
<li>src/KCMTelepathyAccounts/parameter-item.cpp <span style="color: grey">(318f175ec60b0dc31edadb72eda769b791ff9827)</span></li>
<li>src/KCMTelepathyAccounts/protocol-item.cpp <span style="color: grey">(03ac0bceff0f32673a706329f698a66323842c69)</span></li>
<li>src/KCMTelepathyAccounts/protocol-parameter-value.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/KCMTelepathyAccounts/protocol-parameter-value.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/account-item.cpp <span style="color: grey">(50afaa54c96ad51b6775f954cc180d1e12bbe96b)</span></li>
<li>src/add-account-assistant.cpp <span style="color: grey">(3933763957b1448aacf9e6c7efbc6b296a5e3664)</span></li>
<li>src/edit-account-dialog.cpp <span style="color: grey">(73462f2e2a93e22e6d5d67297c575f4e10d44c5c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100293/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>